We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amp
The Amp root namespace is already used by the Amp asynchronous PHP library: https://github.com/amphp/amp/blob/master/lib/Loop.php#L3
We should use a different one to not cause conflicts.
@sebastianbenz suggested aligning with the NPM @ampproject namespace, so we'd use AmpProject as the root namespace for the PHP libraries.
@ampproject
AmpProject
Do not alter or remove anything below. The following sections will be managed by moderators only.
composer.json
The text was updated successfully, but these errors were encountered:
schlessera
Successfully merging a pull request may close this issue.
Feature description
The
Amp
root namespace is already used by theAmp
asynchronous PHP library: https://github.com/amphp/amp/blob/master/lib/Loop.php#L3We should use a different one to not cause conflicts.
@sebastianbenz suggested aligning with the NPM
@ampproject
namespace, so we'd useAmpProject
as the root namespace for the PHP libraries.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
AmpProject
as the root namespace.Implementation brief
composer.json
file will probably need to be adapted manually.Amp
root namespace, we can use class aliases to maintain compatibility.QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: