Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Amp root namespace #4188

Closed
schlessera opened this issue Jan 28, 2020 · 0 comments · Fixed by #4364
Closed

Change Amp root namespace #4188

schlessera opened this issue Jan 28, 2020 · 0 comments · Fixed by #4364
Assignees
Milestone

Comments

@schlessera
Copy link
Collaborator

Feature description

The Amp root namespace is already used by the Amp asynchronous PHP library: https://github.com/amphp/amp/blob/master/lib/Loop.php#L3

We should use a different one to not cause conflicts.

@sebastianbenz suggested aligning with the NPM @ampproject namespace, so we'd use AmpProject as the root namespace for the PHP libraries.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • All namespaced libraries use AmpProject as the root namespace.

Implementation brief

  • A simple "Rename" refactor in PHPStorm will allow this change in a reliable manner across the PHP codebase.
  • The composer.json file will probably need to be adapted manually.
  • Test namespaces should be adapted as well.
  • In case we already released code with the Amp root namespace, we can use class aliases to maintain compatibility.

QA testing instructions

Demo

Changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants