Change Amp root namespace to AmpProject #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@westonruter As far as I can tell, we never released any namespaced code so far, right? Then there are no class aliases needed for backward compatibility. |
schlessera
added
Optimizer
Enhancement
westonruter
approved these changes
Mar 7, 2020
|
Merged in spite of build failure, because failure is due to the dreaded SVG HTTP error not related to the changes here. |
westonruter
added a commit
that referenced
this pull request
Mar 7, 2020
westonruter
added a commit
that referenced
this pull request
Mar 9, 2020
…validation-error * 'develop' of github.com:ampproject/amp-wp: (58 commits) Remove vendor dirs for library if they exist Remove dotenv config Update package-lock.json Update dependency babel-eslint to v10.1.0 (#4344) Update dependency @wordpress/e2e-test-utils to v4.3.1 (#4360) Update dependency react-dom to v16.13.0 (#4348) Update dependency uuid to v7 (#4325) Update dependency eslint-plugin-jest to v23.8.2 (#4346) Update dependency cross-env to v7.0.2 (#4359) Remove now unneeded dotenv dependency Remove extraneous closing brace from add_nav_menu_styles Used fixed-height layout for iframe Add missing allow-popups sandbox for iframe Re-add image assets for tests Improve phpdoc, method names, and remove unnecessary global namespace qualifier Throw Exception instead of Error Wait for server to start Improve static analysis for passing ownerDocument Do capital_K_dangit for TikTok Update namespace reference after #4364 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As noted in #4188, the root namespace
Ampis already taken by an established PHP project.This PR changes the root namespace for all three packages (plugin, common library & optimizer library) from
AmptoAmpProject.Fixes #4188
Checklist