You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While trying to investigate the reason for #4465, I noticed that the constants being used within the protoascii files are reverted to meaningless scalar values in the generated PHP files.
The PHP files should make use of defined constants like the ones defined in AmpProject\Layout or similar, so that it becomes much easier to reason about the generated rules.
Doing this would be complicated given the current spec generator, which takes a data structure and then just does var_export(). This may make most sense to tackle as part of #3875.
Feature description
While trying to investigate the reason for #4465, I noticed that the constants being used within the protoascii files are reverted to meaningless scalar values in the generated PHP files.
The PHP files should make use of defined constants like the ones defined in
AmpProject\Layout
or similar, so that it becomes much easier to reason about the generated rules.Example before (extract):
Example after (extract):
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: