-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validator spec via code generation #100
Conversation
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
============================================
- Coverage 80.87% 72.03% -8.85%
- Complexity 928 1017 +89
============================================
Files 48 65 +17
Lines 2311 2739 +428
============================================
+ Hits 1869 1973 +104
- Misses 442 766 +324
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
db0f8be
to
b284a31
Compare
dc29a61
to
133e694
Compare
f97472f
to
ace33a6
Compare
LGTM ✅ Just kidding. As you noted, I'll have to digest this. Maybe we could step through it next week so I can get a high-level overview before getting into the details? |
c8042c0
to
13cdd18
Compare
13cdd18
to
ca64667
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To do full post-merge review as discussed.
Co-authored-by: Weston Ruter <westonruter@google.com>
See #221. |
This PR adds an object hierarchy that represents the validator spec.
It downloads the JSON version of the validator spec data and uses code generation to build the object hierarchy as a result. The code generation can be manually retriggered for a refresh via the following command:
The generated validator spec is found under
AmpProject\Validator\Spec
(in thesrc/Validator/Spec
subfolder), whereas the code generation is found under (the--dev
only)AmpProject\Tooling\Validator\SpecGenerator
(in thebin/Validator/SpecGenerator
subfolder).