Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validator spec via code generation #100

Merged
merged 109 commits into from
Jun 1, 2021
Merged

Add validator spec via code generation #100

merged 109 commits into from
Jun 1, 2021

Commits on May 26, 2021

  1. Add script to generate validator spec

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    3b8c1a6 View commit details
    Browse the repository at this point in the history

  2. Add PHP generator dependency

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    a46d07f View commit details
    Browse the repository at this point in the history

  3. Add initial tag section support

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    8acc8d6 View commit details
    Browse the repository at this point in the history

  4. Reuse section class name

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    02871ac View commit details
    Browse the repository at this point in the history

  5. Add IDs to tags and sort them accordingly

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    80dcc0f View commit details
    Browse the repository at this point in the history

  6. Add hashed data for tag access by tag name or spec name

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    2a374c1 View commit details
    Browse the repository at this point in the history

  7. Add retrieval methods for tags

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    367a715 View commit details
    Browse the repository at this point in the history

  8. Use relative namespaces in typehints

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    f367ea8 View commit details
    Browse the repository at this point in the history

  9. Add unit tests for spec sections

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    411c8c6 View commit details
    Browse the repository at this point in the history

  10. Add tests for tag retrieval

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    bdda53b View commit details
    Browse the repository at this point in the history

  11. Create tags array in one assignment

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    bc9cfaa View commit details
    Browse the repository at this point in the history

  12. Make bySpecName() return a single Tag instead of an array

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    df3619b View commit details
    Browse the repository at this point in the history

  13. Add docblock for dump() method

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    92c747c View commit details
    Browse the repository at this point in the history

  14. Add temporary internal data for all sections

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    1dc873b View commit details
    Browse the repository at this point in the history

  15. Extract compat testing out of regular PHPCS config

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    ba6fb89 View commit details
    Browse the repository at this point in the history

  16. Use existing tag constants

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    88358f1 View commit details
    Browse the repository at this point in the history

  17. Use constants as tag index

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    3917b65 View commit details
    Browse the repository at this point in the history

  18. Reuse constants in tag keys

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    7c06565 View commit details
    Browse the repository at this point in the history

  19. Reuse constants in tag reference keys

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    27f8d00 View commit details
    Browse the repository at this point in the history

  20. Reuse constants in spec reference keys

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    cebe2cd View commit details
    Browse the repository at this point in the history

  21. Add interface with constants for AMP formats.

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    4ea4113 View commit details
    Browse the repository at this point in the history

  22. Use format constants in tag definitions

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    067f3d0 View commit details
    Browse the repository at this point in the history

  23. Use constants for mandatoryParent

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    bf53d92 View commit details
    Browse the repository at this point in the history

  24. Use constants for mandatoryAncestor

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    2178598 View commit details
    Browse the repository at this point in the history

  25. Use constants for mandatoryAncestorSuggestedAlternative

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    7d452be View commit details
    Browse the repository at this point in the history

  26. Avoid constants for (broken) multi-word tags

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    8ed42c8 View commit details
    Browse the repository at this point in the history

  27. Use custom array dumping with callback support

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    1dafa33 View commit details
    Browse the repository at this point in the history

  28. Use constants for ampLayout > supportedLayouts

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    7feebc3 View commit details
    Browse the repository at this point in the history

  29. Refactor main generator loop

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    50570fe View commit details
    Browse the repository at this point in the history

  30. Use helper method for creating Tag class file

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    522cbe4 View commit details
    Browse the repository at this point in the history

  31. Add interface with error code constants

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    1a9a544 View commit details
    Browse the repository at this point in the history

  32. Improve error mappings

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    30cc18f View commit details
    Browse the repository at this point in the history

  33. Refactor single-value sections into properties

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    5508c6e View commit details
    Browse the repository at this point in the history

  34. Rearrange descendant tag lists

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    effc3e4 View commit details
    Browse the repository at this point in the history

  35. Rearrange and refactor declaration lists

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    ae78c65 View commit details
    Browse the repository at this point in the history

  36. Write tests for retrieving declaration lists

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    09f4681 View commit details
    Browse the repository at this point in the history

  37. Add tests for declaration list

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    3534f44 View commit details
    Browse the repository at this point in the history

  38. Add CSS rules management

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    8c13ec0 View commit details
    Browse the repository at this point in the history

  39. Rename cssRules section back to css

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    38ed92e View commit details
    Browse the repository at this point in the history

  40. Refactor declaration lists and include attribute lists

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    a66af99 View commit details
    Browse the repository at this point in the history

  41. Add spec rule constants

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    7d2e844 View commit details
    Browse the repository at this point in the history

  42. Include more spec rules

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    bdd7e0b View commit details
    Browse the repository at this point in the history

  43. Add querying of tags by HTML format

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    0500995 View commit details
    Browse the repository at this point in the history

  44. Add tests for byFormat querying

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    c7ed552 View commit details
    Browse the repository at this point in the history

  45. Avoid cast to array

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    f20cf7d View commit details
    Browse the repository at this point in the history

  46. Use extension name for script tag IDs

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    c8cf8bb View commit details
    Browse the repository at this point in the history

  47. Refactor file handling into a separate FileManager object

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    4aefda7 View commit details
    Browse the repository at this point in the history

  48. Refactor VariableDumping trait into a Dumper instance

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    463fff1 View commit details
    Browse the repository at this point in the history

  49. Adapt spec attributes within tag classes

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    492b4fe View commit details
    Browse the repository at this point in the history

  50. Automatically add missing imports

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    6429401 View commit details
    Browse the repository at this point in the history

  51. Avoid php language constructs as class names

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    bf8d18d View commit details
    Browse the repository at this point in the history

  52. Refactor tags internal storage

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    3704a45 View commit details
    Browse the repository at this point in the history

  53. Use constants for protocol

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    2e68588 View commit details
    Browse the repository at this point in the history

  54. Use constants for requiresExtension

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    09a3510 View commit details
    Browse the repository at this point in the history

  55. Add missing spec rule constants

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    0f59e0b View commit details
    Browse the repository at this point in the history

  56. Add constants for trigger rule

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    ab83fbe View commit details
    Browse the repository at this point in the history

  57. Add constants for alternative names rule

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    7c8abfe View commit details
    Browse the repository at this point in the history

  58. Reuse same dumping logic for all sections

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    d908aad View commit details
    Browse the repository at this point in the history

  59. Use constants for i-amphtml-layout rule

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    b0c63ce View commit details
    Browse the repository at this point in the history

  60. Use constants for enabledBy & disabledBy rules

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    e45bec8 View commit details
    Browse the repository at this point in the history

  61. Use constants for name rule

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    d4e8d7e View commit details
    Browse the repository at this point in the history

  62. Add more spec rule constants

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    5411fdf View commit details
    Browse the repository at this point in the history

  63. Add more defaults values to tag class

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    c0f68f7 View commit details
    Browse the repository at this point in the history

  64. Add extension spec access

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    519d752 View commit details
    Browse the repository at this point in the history

  65. Remove unused code in FileManager

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    f37f500 View commit details
    Browse the repository at this point in the history

  66. Turn lists into arrays of constants

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    23c1941 View commit details
    Browse the repository at this point in the history

  67. Adapt handling of extension specs

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    4db3d01 View commit details
    Browse the repository at this point in the history

  68. Update to latest spec

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    901d148 View commit details
    Browse the repository at this point in the history

  69. Fix getLatestVersion and add test

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    a14149b View commit details
    Browse the repository at this point in the history

  70. Add name and type queries to extension spec trait

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    1ec5306 View commit details
    Browse the repository at this point in the history

  71. Add missing interface method declarations for extension spec

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    4652f7f View commit details
    Browse the repository at this point in the history

  72. Add link to PHPStan bug issue in ignore config

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    d6abd11 View commit details
    Browse the repository at this point in the history

  73. Point to new issue in PHPStan config comment

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    4967dad View commit details
    Browse the repository at this point in the history

  74. Re-add attribute constant that was lost on rebase

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    90ed747 View commit details
    Browse the repository at this point in the history

  75. Update from JSON spec - 2021-03-16

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    cbe4433 View commit details
    Browse the repository at this point in the history

  76. Use lower version of PHP generator engine

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    c94741b View commit details
    Browse the repository at this point in the history

  77. Add PHP code generator package to Composer suggestions

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    c5389bc View commit details
    Browse the repository at this point in the history

  78. Fail gracefully when PHP generator is not present

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    6e2b7c2 View commit details
    Browse the repository at this point in the history

  79. Update constants in Tags section

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    513b12a View commit details
    Browse the repository at this point in the history

  80. Ignore bin/ folder for code coverage

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    159a54e View commit details
    Browse the repository at this point in the history

  81. Make Tags object iterable

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    315a4e1 View commit details
    Browse the repository at this point in the history

  82. Update to latest spec - 2021-03-29

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    b8637be View commit details
    Browse the repository at this point in the history

  83. Add tests for exceptions

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    5fec999 View commit details
    Browse the repository at this point in the history

  84. Refactor iteration array initialization

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    c1c50a1 View commit details
    Browse the repository at this point in the history

  85. Fix test failures

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    4f1f5e8 View commit details
    Browse the repository at this point in the history

  86. Update to latest spec - 2021-04-30

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    2b29c7a View commit details
    Browse the repository at this point in the history

  87. Add missing spec rule keys to dumper

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    7a95cca View commit details
    Browse the repository at this point in the history

  88. Improve attribute lists section

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    895ce1c View commit details
    Browse the repository at this point in the history

  89. Update spec

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    1f86857 View commit details
    Browse the repository at this point in the history

  90. Remove bad extend

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    8733946 View commit details
    Browse the repository at this point in the history

  91. Refactor declaration and descendant tag lists

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    0325f36 View commit details
    Browse the repository at this point in the history

  92. Use constants for attribute list IDs

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    2be3767 View commit details
    Browse the repository at this point in the history

  93. Remove PHP code generator dependency again

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    31bf3b3 View commit details
    Browse the repository at this point in the history

  94. Add missing docblocks

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    35e806a View commit details
    Browse the repository at this point in the history

  95. Refactor ID retrieval

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    6406cdf View commit details
    Browse the repository at this point in the history

  96. Reuse tag IDs as constants

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    4083fe8 View commit details
    Browse the repository at this point in the history

  97. Improve tests for individual entities

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    039eda8 View commit details
    Browse the repository at this point in the history

  98. Improve test cover annotations

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    a2c6db1 View commit details
    Browse the repository at this point in the history

  99. Refactor CSS rulesets

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    1ba80ec View commit details
    Browse the repository at this point in the history

  100. Refactor doc section

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    2eb8982 View commit details
    Browse the repository at this point in the history

  101. Add missing exception tests

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    a0a69ef View commit details
    Browse the repository at this point in the history

  102. Refactor errors section

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    ca64667 View commit details
    Browse the repository at this point in the history

  103. Remove duplicate bin exclusion in codecov config

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    3944808 View commit details
    Browse the repository at this point in the history

  104. Remove unneeded files

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    901b2cf View commit details
    Browse the repository at this point in the history

  105. Improve automatic import additions

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    1312057 View commit details
    Browse the repository at this point in the history

  106. Improve docblocks for generated classes

    @schlessera
    schlessera committed May 26, 2021
    Configuration menu
    Copy the full SHA
    65839b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Fix spelling

    @westonruter
    westonruter committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    801419d View commit details
    Browse the repository at this point in the history

  2. Add progress messages to generate-validator-spec.php

    @westonruter
    westonruter committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    7d9a1c1 View commit details
    Browse the repository at this point in the history

  3. Fix blank line CS fail 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @schlessera @westonruter
    schlessera and westonruter authored Jun 1, 2021
    Configuration menu
    Copy the full SHA
    1004f23 View commit details
    Browse the repository at this point in the history