Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests are broken on WordPress trunk due to loading=lazy #4563

Closed
westonruter opened this issue Apr 10, 2020 · 0 comments · Fixed by #4564
Closed

Unit tests are broken on WordPress trunk due to loading=lazy #4563

westonruter opened this issue Apr 10, 2020 · 0 comments · Fixed by #4564
Assignees
Labels
Bug Something isn't working Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs
Milestone

Comments

@westonruter
Copy link
Member

Bug Description

These tests are currently failing in WordPress trunk due to the introduction of loading=lazy (see r47554):

1) AMP_Gallery_Embed_Handler_Test::test__conversion with data set "shortcode_with_lightbox" ('[gallery amp-lightbox=true am...id3}}]', '<style type='text/css'> #gall...</div>')
2) AMP_Gallery_Embed_Handler_Test::test__conversion with data set "shortcode_with_lightbox_linking_to_file" ('[gallery amp-lightbox=true am...id3}}]', '<style type='text/css'> #gall...</div>')
3) Test_AMP_YouTube_Embed_Handler::test__conversion with data set "url_simple" ('https://www.youtube.com/watch...bJY0\n', '<p><amp-youtube data-videoid=...</p>\n', '<p><amp-youtube data-videoid=...</p>\n')
4) Test_AMP_YouTube_Embed_Handler::test__conversion with data set "url_short" ('https://youtu.be/kfVsfOSbJY0\n', '<p><amp-youtube data-videoid=...</p>\n', '<p><amp-youtube data-videoid=...</p>\n')
5) Test_AMP_YouTube_Embed_Handler::test__conversion with data set "url_with_querystring" ('http://www.youtube.com/watch?...=349\n', '<p><amp-youtube data-videoid=...</p>\n', '<p><amp-youtube data-videoid=...</p>\n')
6) Test_AMP_YouTube_Embed_Handler::test__conversion with data set "embed_url" ('https://www.youtube.com/embed...bJY0\n', '<p><amp-youtube data-videoid=...</p>\n', '<p><amp-youtube data-videoid=...</p>\n')
7) Test_AMP_Validation_Manager::test_decorate_shortcode_and_filter_source

Expected Behaviour

You shall not fail!


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added Bug Something isn't working Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs labels Apr 10, 2020
@westonruter westonruter added this to the v1.5.3 milestone Apr 10, 2020
@pierlon pierlon self-assigned this Apr 10, 2020
@pierlon pierlon mentioned this issue Apr 10, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants