Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #4564

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Fix unit tests #4564

merged 2 commits into from
Apr 10, 2020

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Apr 10, 2020

Summary

Fixes #4563.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Apr 10, 2020
@westonruter westonruter added this to the v1.5.3 milestone Apr 10, 2020
@westonruter
Copy link
Member

Thank you.

@westonruter westonruter merged commit ae74baa into develop Apr 10, 2020
@westonruter westonruter deleted the fix/4563-broken-unit-tests branch April 10, 2020 16:55
westonruter pushed a commit that referenced this pull request Apr 10, 2020
* Fix unit tests

* Add loading attribute depending on WP version
westonruter added a commit that referenced this pull request Apr 15, 2020
* tag '1.5.3':
  Bump 1.5.3
  Bump version to 1.5.3-RC1
  Fix handling of Mustache templates (#4583)
  Stub request based on test scenario (#4588)
  Update tests after block-library/style.css changes in Gutenberg 7.9 (#4579)
  Restrict doing plugin upgrade routine when not in admin (#4538)
  Add new accessibility sanitizer (#4535)
  Fix unit tests (#4564)
  Add button into Site Health to reenable CSS transient caching (#4522)
  Restore unification of multi-page post content in Reader mode (#4547)
  Prevent styles from being removed when in Customizer preview with Standard mode (#4553)
  Omit Jetpack from being activated during PHPUnit test runs (#4474)
  Mock Facebook embed tests (#4474)
  Mock Imgur embed tests (#4474)
  Use title case for Paired Browsing link in edit post screen (#4540)
  Ensure that validation query vars persist through redirects (#4544)
  Add requirements to plugin file header (#4543)
  Force status code of validation responses to be 200 (#4533)
  Update optimizer test specs (#4527)
  Bump 1.5.3-alpha
pierlon added a commit that referenced this pull request May 22, 2020
* Fix unit tests

* Add loading attribute depending on WP version

(cherry picked from commit 4f9ac9c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests are broken on WordPress trunk due to loading=lazy
3 participants