Ensure that validation query vars persist through redirects #4544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given a plugin that performs a redirect, such as the contrived example which redirects any AMP page to automatically get
redirected=1
added as an additional query var:At the moment for a site in Transitional mode, going to a non-AMP page at
/about/
and clicking Validate in the admin bar results in:The issue is that the
amp_validate
query var was not persisting across redirects, so this PR fixes that problem so that this is now the result when attempting to validate/about/
on a Transitional mode site:This issue came up specifically where WPML was attempting to redirect the homepage to
/en/
in this support topic: https://wordpress.org/support/topic/url-validation-failed-due-to-unexpected-json-in-amp-validation-response/#post-12637035Checklist