-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build reference test site #4571
Comments
I will be happy to do that. Can this issue be assigned to me? |
Hey @amanintech, thanks for the interest in working on this. We're currently not sure whether this can be done by an outside contributor, as it might require quite a lot of infrastructural knowledge to pull off. But I guess it depends on how we approach it. Can you give me a few details about how you intend to work on this and what you'd want to build exactly? |
I would do something like exactly as you mentioned with a Wordpress website having the latest AMP plugin. I can add a CI that updates the plugin automatically and send the lighthouse performance report. We can host real content by pulling it from a news website in form of feed. I have worked on a repo where I also developed a theme having a feed like a feature. https://kievents.co/sid/ |
To make this maintainable in the project and usable inside CI builds I think the test site should be in a Docker container. |
Yes, or maybe even a docker composer setup (instead of a single container), as we'll want to test persistent object caching as well with different servers like Memcached or Redis. It should be the "source" version of building such a site, not the end result, so that we can replicate it wherever we need it. Is this something you can tackle, @amanintech ? |
Yes, I surely can try. Where this container should be finally deployed? And will the site have any public visibility ? |
I think the point of the container is that it won't be deployed publicly. It would be spun up during and inside CI builds and then destroyed. |
This is definitely something we need to do to evaluate baseline performance metrics for sites running the plugin on a set of specific conditions in relation to as set of essential metrics. Priorities are:
After these are achieved:
|
Honestly, I have never done that before. But I am ready to learn and give it a shot if that's ok. Could you share any tutorial to help me get started? |
@amanintech I think what @amedina meant to say is that we - as in: the internal AMP plugin team - have to do a lot of work upfront until this is ready for a first implementation. I'm afraid this is not a good issue for now if you are interested in contributing. |
Got it |
We should work on a reference test site that includes typical website content and try to use or touch most or all of the functionality of the AMP plugin as a real-world website would.
This will either simplify or be a requirement for the following features:
The text was updated successfully, but these errors were encountered: