-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated visual regression testing #4671
Comments
Should we expand this to having both visual and performance regression testing? The former to track AMP Content generation (and the visual impact of the optimized content), and the latter to track core web vitals and other metrics. We can also split it into separate issues. |
For generating a site with unit test data and creating a monster post, here's what I've used in the past: https://github.com/westonruter/amp-wp-theme-compat-analysis/blob/913d6f7f18682b092db7657cae970da8e0d1c5c5/start.sh#L19-L40 |
Playing around with the preload hero image transformer makes it obvious we need better ways of testing sanitizers and optimizers. I'm prioritising this so we can build transformers like the preload hero images one with confidence. |
Note: we have a Percy license for the AMP plugin that we can use for this, which is also what Web Stories use. |
Feature description
We're close to a point where we practically have feature parity with non-AMP in most use cases.
Because of that, there are a few scenarios in the plugin by now that could highly benefit from automated visual regression testing:
This can be done more or less efficiently with any of the popular visual regression testing tools like BackstopJS or AyeSpy with the current process:
Benefits:
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: