You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are currently always pulling the latest spec files from the [ampproject/amp-toolbox](https://github.com/ampproject/amp-toolbox project) to run the language-agnostic spec tests against our optimizer implementation.
This also happens in the separate 1.5 branch that we have open for bug fixes. However, while this causes the 1.5 branch to always run against the latest spec file tests, this branch does not get the latest updates to the Optimizer that would fix the code to make updated tests pass if behavior has changed upstream.
Expected Behaviour
The 1.5 branch (and any future release branch that is split off of develop) should be version-locked into a specific set of spec files to test against that is known to work.
Bug Description
We are currently always pulling the latest spec files from the [
ampproject/amp-toolbox
](https://github.com/ampproject/amp-toolbox project) to run the language-agnostic spec tests against our optimizer implementation.This also happens in the separate 1.5 branch that we have open for bug fixes. However, while this causes the 1.5 branch to always run against the latest spec file tests, this branch does not get the latest updates to the Optimizer that would fix the code to make updated tests pass if behavior has changed upstream.
Expected Behaviour
The 1.5 branch (and any future release branch that is split off of
develop
) should be version-locked into a specific set of spec files to test against that is known to work.Steps to reproduce
composer install
withinlib/optimizer
foldercomposer test
withinlib/optimizer
folderScreenshots
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: