Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locking code to develop branch as preparation #4826

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Add locking code to develop branch as preparation #4826

merged 1 commit into from
Jun 9, 2020

Conversation

schlessera
Copy link
Collaborator

Summary

Adds code for version-locking the spec tests in release branches.

See #4824 (actual fix is in #4825)

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@schlessera schlessera added Optimizer Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs labels Jun 9, 2020
@googlebot googlebot added the cla: yes Signed the Google CLA label Jun 9, 2020
@westonruter westonruter added this to the v1.6 milestone Jun 9, 2020
@westonruter westonruter merged commit 4743ae5 into develop Jun 9, 2020
@westonruter westonruter deleted the fix/4824-prepare-develop-for-locking-release-branches branch June 9, 2020 07:24
@westonruter westonruter mentioned this pull request Jun 9, 2020
Closed
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. cla: yes Signed the Google CLA Optimizer Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@schlessera @westonruter @googlebot