-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPUnit test workflow for multisite #5701
Comments
@westonruter I am planning to add multisite tests workflow using wp-env. Which WP and PHP versions it should cover? or it should be the same as current test workflows. In this case, we will be having 2x test workflows. |
Just adding one additional test with the latest WP version and PHP 7.4 should be good, as that corresponds to the majority of installs. |
As part of this, could you also add a local development command using the Docker environment to test multisite? Maybe you're planning to do that anyway for debugging the current failures anyway. |
I have added it as a command and it uses the wp-env. Line 146 in ac70da5
|
QA Passed ✅ PHPUnit tests workflow for multisite is up and running with PHP 7.4 and WP latest. See job or explore the action runs for the |
Feature description
Some relatively recent additions to the plugin have involved small customizations related to multisite environments (example). Currently we only run PHPUnit tests in single-site environments, so there's no easy way to write tests for these features.
Potentially useful for reference:
https://github.com/WordPress/wordpress-develop/blob/master/tests/phpunit/multisite.xml
https://github.com/WordPress/wordpress-develop/blob/master/.github/workflows/phpunit-tests.yml#L257
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: