-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPUnit tests workflow for multisite #7321
Conversation
8f6424d
to
b8007c0
Compare
b8007c0
to
8997b11
Compare
0780fd4
to
15fa7dd
Compare
15fa7dd
to
ac70da5
Compare
@westonruter I have configured workflow for both testsuites i.e. |
Interesting. Yes, they should be fixed in this PR. For each failure, I'd suggest checking to see what the cause of the failure is. It may be due to a regular admin user not having all the same privileges as a superadmin on multisite. Therefore the fix may be just to check if its multisite, and then grant the user being tested with superadmin privileges. Some tests probably also should be skipped if the functionality specifically is not available in multisite. For example, installing themes from the onboarding wizard I don't think is available on multisite. It'll be interesting to see if this uncovers actual bugs with the code and not just incomplete tests! |
5341d82
to
b84213d
Compare
Mock a new blog to create posts for AMP paired mode testing
@westonruter I believe the capability here should be amp-wp/src/Admin/AfterActivationSiteScan.php Line 214 in 650a4eb
|
… in multisite env
…er admin access in multisite env
…sed_for_template_mode to have super admin access in multisite env
…te_reader_theme Update user privialge in multisite env and pass themes in wp_prepare_themes_for_js()
…B queries in multisite env
4748f1f
to
4dc01a4
Compare
5c956d8
to
88fb246
Compare
5e64f53
to
deb6e3c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7321 +/- ##
=============================================
- Coverage 78.60% 77.80% -0.81%
Complexity 6852 6852
=============================================
Files 209 276 +67
Lines 18655 19814 +1159
=============================================
+ Hits 14664 15416 +752
- Misses 3991 4398 +407
Flags with carried forward coverage won't be shown. Click here to find out more.
|
17dd543
to
deb6e3c
Compare
@thelovekesh yes, I think you're right. The page requires |
Co-authored-by: Weston Ruter <westonruter@google.com>
…l to mock super admin user in multisite
Summary
Fixes #5701
This PR also updates deprecated
set-output
commands in GitHub Actions workflow files. See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/Checklist