Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sanitizer for auto-lightbox disabling to target root element instead of body #7057

Closed
westonruter opened this issue Apr 14, 2022 · 1 comment · Fixed by #7097
Closed
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Milestone

Comments

@westonruter
Copy link
Member

westonruter commented Apr 14, 2022

Feature Description

Based on ampproject/amphtml#37854 (comment) it turns out that now if you add data-amp-auto-lightbox-disable to the root html element, not only will the auto-lightbox behavior be disabled but also the auto-lightbox script will also be prevented from being autoloaded. So we need to update AMP_Auto_Lightbox_Disable_Sanitizer (introduced in #6936 for #5122) to make that change.

Acceptance Criteria

The data-amp-auto-lightbox-disable attribute should be added to the html element instead of the body element.

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@westonruter westonruter added Bug Something isn't working Enhancement New feature or improvement of an existing one labels Apr 14, 2022
@westonruter westonruter added this to the v2.3 milestone Apr 14, 2022
@westonruter westonruter removed the Enhancement New feature or improvement of an existing one label Apr 14, 2022
@dhaval-parekh dhaval-parekh self-assigned this May 11, 2022
@pooja-muchandikar
Copy link

QA Passed ✅

data-amp-auto-lightbox-disable attribute is shown in HTML tag instead of body tag.

Before: data-amp-auto-lightbox-disable attribute in body tag

Screenshot 2022-06-07 at 11 22 19 AM


After: data-amp-auto-lightbox-disable attribute in HTML tag

Screenshot 2022-06-07 at 11 23 00 AM


@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
3 participants