Add 'data-amp-auto-lightbox-disable' attribute to HTML tag instead of body tag to disable auto-lightbox #7097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 3d45623 are ready 🛎️!
|
westonruter
requested changes
May 11, 2022
… body tag to disable auto-lightbox
dhaval-parekh
force-pushed
the
bug/7057-auto-lightbox
branch
from
4187b22
to
ce0a421
Compare
westonruter
reviewed
May 12, 2022
| @@ -35,6 +35,8 @@ describe( 'Featured Image Notice', () => { | |||
|
|
|||
| // This should not suggest cropping. | |||
| await expect( page ).not.toMatch( cropImageText ); | |||
|
|
|||
| await clickButton( 'Featured image' ); | |||
There was a problem hiding this comment.
Was the E2E test failure a fluke? It doesn't seem that adding this click here should do anything since it is done in beforeEach anyway and there are no expectations in this test.
westonruter
approved these changes
May 12, 2022
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7057
Checklist