We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi! I wanted to let you know that it's now possible to add items under "Preview" menu in Gutenberg since:
More here: https://make.wordpress.org/core/2024/10/18/extending-the-preview-dropdown-menu-in-wordpress-6-7/
I recommend moving the AMP preview there from the plugin toolbar conditionally when PreviewDropdownMenuItem is available:
PreviewDropdownMenuItem
The original issue at Gutenberg repo used AMP as an example of why the Preview dropdown had to be extendable:
I wrote more ideas here on how to improve preview extensibility. Feel free to share AMP perspective!
The text was updated successfully, but these errors were encountered:
Perhaps for another issue, but I noticed the 'Preview in new tab' line has more left/right padding than the rest of the items.
Sorry, something went wrong.
This is great as I understand it will eliminate some brittle code we've had to implement to work around this limitation:
https://github.com/ampproject/amp-wp/blob/60a655cdad9e3431b47b2dcc3b2e5ddb86ac5c5e/assets/src/block-editor/plugins/wrapped-amp-preview-button.js
thelovekesh
Successfully merging a pull request may close this issue.
Hi! I wanted to let you know that it's now possible to add items under "Preview" menu in Gutenberg since:
More here: https://make.wordpress.org/core/2024/10/18/extending-the-preview-dropdown-menu-in-wordpress-6-7/
I recommend moving the AMP preview there from the plugin toolbar conditionally when
PreviewDropdownMenuItem
is available:The original issue at Gutenberg repo used AMP as an example of why the Preview dropdown had to be extendable:
I wrote more ideas here on how to improve preview extensibility. Feel free to share AMP perspective!
The text was updated successfully, but these errors were encountered: