Relocate AMP Preview Button #7914
Conversation
|
|
| @@ -221,37 +220,36 @@ class AmpPreviewButton extends Component { | |||
| isEnabled && | |||
| !errorMessages.length && | |||
| !isStandardMode && ( | |||
| <Button | |||
| <PluginPreviewMenuItem | |||
There was a problem hiding this comment.
We'll need to make sure that if PluginPreviewMenuItem doesn't exist due to not being on the latest version of WordPress that we short-circuit this function so we don't get an error.
thelovekesh
force-pushed
the
feature/7896-refactor-amp-preview-button
branch
from
b3f30f6
to
67bf045
Compare
| @@ -1,4 +1,5 @@ | |||
| FROM wordpress | |||
| # @todo: switch to wordpress:latest once it's available | |||
| FROM wordpress:beta-6.7-php8.3-apache | |||
There was a problem hiding this comment.
Required to test AMP preview button changes.
|
JS Unit tests are (not) failing because codecov is unable to upload reports of the PR from fork. |
|
I noticed that the button of the AMP icon is ever so slightly cut off:
|
| export const name = 'amp-preview-menu-item'; | ||
|
|
||
| export const icon = ( | ||
| <AMPFilledIcon viewBox="0 0 62 62" height={18} width={18} /> |
There was a problem hiding this comment.
The styling of the menu items is a bit different:
Maybe this is contributing to the icon being cropped at the bottom.
There was a problem hiding this comment.
If I make the icon have the 24x24 pixel dimensions then it isn't cropped. But then it's probably too big.
There was a problem hiding this comment.
Interesting, With the latest build on this PR, it looks like
There was a problem hiding this comment.
Likewise @thelovekesh, The latest build doesn't have the cropping issue on any breakpoints.
There was a problem hiding this comment.
Hummm. I still see it cropped with after doing a fresh npm run build:prod:
If I increase my browser's zoom level from 100% to 110% then the issue goes away:
Maybe it's a ChromeOS-specific rendering issue? In any case, not critical. Would still be good to debug further.
|
As expected, in 6.6.x I'm not seeing any preview button:
And when updating to 6.7-RC5 I see the button as expected:
|
|
This seems to work well. The only outstanding item is the slight cropping on the icon. |
Summary
PluginPreviewMenuItem.Checklist