-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate AMP Preview Button #7914
Changes from all commits
c63acbe
cea5ea7
67bf045
1dfff7a
973d9d5
9248c2e
c92e46a
6844482
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/** | ||
* Internal dependencies | ||
*/ | ||
import { AMPFilledIcon } from '../../icons'; | ||
import AmpPreviewMenuItem from '../components/preview-menu-item'; | ||
|
||
export const name = 'amp-preview-menu-item'; | ||
|
||
export const icon = ( | ||
<AMPFilledIcon viewBox="0 0 62 62" height={18} width={18} /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I make the icon have the 24x24 pixel dimensions then it isn't cropped. But then it's probably too big. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Likewise @thelovekesh, The latest build doesn't have the cropping issue on any breakpoints. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
); | ||
|
||
export const onlyPaired = true; | ||
|
||
export const render = AmpPreviewMenuItem; |
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to make sure that if
PluginPreviewMenuItem
doesn't exist due to not being on the latest version of WordPress that we short-circuit this function so we don't get an error.