improve sanitization in jetpack_amp_build_stats_pixel_url() #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts_pixel_url(); sanitize HTTP_HOST
westonruter
previously requested changes
Mar 8, 2018
| @@ -63,7 +63,7 @@ function jetpack_amp_build_stats_pixel_url() { | |||
| $data = compact( 'v', 'j', 'blog', 'post', 'tz', 'srv' ); | |||
| } | |||
|
|
|||
| $data['host'] = isset( $_SERVER['HTTP_HOST'] ) ? rawurlencode( $_SERVER['HTTP_HOST'] ) : ''; // input var ok | |||
| $data['host'] = isset( $_SERVER['HTTP_HOST'] ) ? sanitize_text_field( wp_unslash( $_SERVER['HTTP_HOST'] ) ) : ''; // input var ok | |||
There was a problem hiding this comment.
sanitize_text_field is not equivalent to rawurlencode
There was a problem hiding this comment.
Does rawurlencode() count as a sanitizing function? If not, should another one be used? If not, should WPCS be updated?
There was a problem hiding this comment.
Nevermind. I supose this change is ok. You can cherry-pick this into #1002 as well.
|
See #1002 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rawurlencode()on$data—array_map()already does this