Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install service worker to cache AMP CDN assets, cache Google Fonts, and cache images (following AMP by Example) #1261
Install service worker to cache AMP CDN assets, cache Google Fonts, and cache images (following AMP by Example) #1261
Changes from 33 commits
bc57707
d0ed452
43ba855
71cb091
0536a1e
f708adf
0d68201
02fd0a7
01408ca
4c5eff9
3041d88
cc0e49a
e7c5dd9
fadfb21
831b158
ea6a9cd
f2ad472
15e3c5f
dbc0c86
40a1e2e
da6a6f2
9c35c3d
55525e1
fbed16d
5cbc6b3
80dc2d1
33bb93b
a1cb0cd
18915f2
b6862e2
82bc980
05172f8
1038397
0b51923
7fec746
1ef6fbb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to have the check for the correct class as well, like the above (without
_doing_it_wrong()
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the other comments above.