Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jed localization error in Classic mode #1341

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Fix Jed localization error in Classic mode #1341

merged 1 commit into from
Aug 16, 2018

Conversation

westonruter
Copy link
Member

Fixes issue when open the Gutenberg editor in Classic mode:

image

@westonruter westonruter added this to the v1.0 milestone Aug 16, 2018
swissspidy
swissspidy approved these changes Aug 16, 2018
View reviewed changes
Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably would have kept amp-editor-blocks-build / before, but the result should be identical.

@westonruter
Copy link
Member Author

Thanks. The issue is that amp-editor-blocks-build is not enqueued in classic mode, so that is why it switches to wp-i18n.

@westonruter westonruter merged commit b77ee6b into develop Aug 16, 2018
@westonruter westonruter deleted the fix/jed-error branch August 16, 2018 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @swissspidy