Update coding standards and fix all violations #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file for concrete versions.
…nts to phpcs.xml and manual modifications.
westonruter
requested changes
Jan 15, 2019
…on lock file for concrete versions." This reverts commit d8d62d1. We'll let Renovate handle dependency updates.
westonruter
approved these changes
Jan 15, 2019
1 task
|
Awesome to have this done! |
|
Very nice indeed.
Em ter, 15 de jan de 2019 às 12:58, Weston Ruter <notifications@github.com>
escreveu:
… Awesome to have this done!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1810 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAe46Y4iZeSLWNFCvaoxF2JRwu026rk_ks5vDkDfgaJpZM4aAx_G>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates WPCS and PHPCompatibility to its latest versions. It furthermore ensures that they stay up to date within non-breaking versions, with the concrete versions of course continuing to be managed withcomposer.lock(runcomposer installto install the tested versions andcomposer updateto potentially update).Furthermore this PR fixes all violations that have been around in the codebase, and it removes the old
// WPCS: ... ok.annotations that are no longer preferable and will be deprecated in the future.