Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing FasterImage and Stream vendor dependencies in builds #1841

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Add missing FasterImage and Stream vendor dependencies in builds #1841

merged 1 commit into from
Jan 30, 2019

Conversation

westonruter
Copy link
Member

Amends #1809.

This may be obsoleted by #1836 but it should be added now so that builds are not broken.

@westonruter westonruter added this to the v1.1 milestone Jan 28, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Jan 28, 2019
felixarntz
felixarntz approved these changes Jan 30, 2019
View reviewed changes
Copy link
Collaborator

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, although this will indeed become invalid later.

@westonruter westonruter merged commit 3654f02 into develop Jan 30, 2019
@westonruter westonruter deleted the fix/build-vendor-bundle branch January 30, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@westonruter @felixarntz @googlebot