-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add noscript fallbacks for img, audio, and video; improve audio conversion to amp-audio; add AMP [fallback] for amp-audio/amp-video #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
commented
Feb 11, 2019
westonruter
changed the title
[WIP] Append original img to amp-img under noscript for no-JS browsers
Append original img to amp-img under noscript for no-JS browsers
Feb 13, 2019
* Add width=auto to audio for fixed-height layout. * Add support for track elements. * Copy all attributes from audio to amp-audio. * Eliminate pointless width/height.
westonruter
changed the title
Append original img to amp-img under noscript for no-JS browsers
Add noscript fallbacks for img, audio, and video; improve audio conversion to amp-audio
Feb 15, 2019
westonruter
changed the title
Add noscript fallbacks for img, audio, and video; improve audio conversion to amp-audio
Add noscript fallbacks for img, audio, and video; improve audio conversion to amp-audio; add AMP [fallback] for amp-audio/amp-video
Feb 15, 2019
swissspidy
approved these changes
Feb 18, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appends original
img
toamp-img
undernoscript
for no-JS browsers. This is recommended by AMP:So, given an
img
element:Before this would be sanitized as:
But after this change it would be:
This also short-circuits the
img
,video
, andaudio
sanitizers for elements that are inside ofnoscript
elements. Similarly, the AMP equivalent towp_mediaelement_fallback()
is implemented so that there arefallback
links inside theamp-audio
elements.Audio Improvements
Audio non-AMP
AMP Audio before changes in PR
AMP Audio after changes in PR
Video Fallbacks
Non-AMP Video
Before PR AMP Video
After PR AMP Video
Fixes #1832.