Update ESLint configuration #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2019
westonruter
reviewed
Feb 19, 2019
westonruter
approved these changes
Feb 20, 2019
westonruter
reviewed
Feb 20, 2019
| "timeago.js": "3.0.2", | ||
| "webpack": "4.29.5", | ||
| "webpack-cli": "3.2.3" | ||
| }, | ||
| "main": "blocks/index.js", | ||
| "scripts": { | ||
| "build": "grunt build && grunt create-build-zip", | ||
| "build": "npm-run-all build:*", |
There was a problem hiding this comment.
Is this going to be stable? Could it not result in zip being run before prepare? Objects in JS do not have ordered keys, unless NPM explicitly sorts them by key when globbing like this. Do you have confirmation?
There was a problem hiding this comment.
So far I have never had any problems with the order being mixed up by npm-run-all or something.
Objects in JS do not have ordered keys
I thought this changed a bit with ES2015?
Do you have confirmation?
According to the author, it executes tasks in definition order in package.json. mysticatea/npm-run-all#116 (comment)
I haven't looked at the code of NPM or the package though to see how order is determined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1766 since updating ESLint took a bit more effort.
In particular:
eslinteslint-plugin-reactbabel-eslintso that ESLint is actually able to parse the JSX source fileseslint-plugin-reactdoesn't throw a warningAs a bonus, I added the
lintnpm script so that one can just typenpm run lint