Code

[WIP] [AMP Stories] Block Rotation#2014

Code

Merged

swissspidy merged 40 commits intoamp-stories-reduxampproject/amp-wp:amp-stories-reduxfrom amp-story/2005-rotationampproject/amp-wp:amp-story/2005-rotationCopy head branch name to clipboardApr 11, 2019

+401-27

Commits

Commits on Mar 21, 2019

• Begin with RotatableBox implementation

  swissspidy

  committed
  37d4aaa

• Merge branch 'amp-stories-redux' into amp-story/2005-rotation

  swissspidy

  committed
  77e33be

• Improve selectors for various block states

  swissspidy

  committed
  057dd84

• Attach event listeners to document

  swissspidy

  committed
  d2fecc5

• Reset rotation at the end for now

  swissspidy

  committed
  e285000

• Fix selector

  swissspidy

  committed
  0bf826e

Commits on Mar 25, 2019

• Fix angle calculation

  swissspidy

  committed
  82cd82c

• Don’t show resize handles when just hovering over page

  swissspidy

  committed
  4b46248

• Improve visibility of rotation handler

  swissspidy

  committed
  0977091

• Fix hook namespace

  swissspidy

  committed
  42d4dc8

• Import keycodes component

  swissspidy

  committed
  8e1a769

• Improve CSS specificity

  swissspidy

  committed
  65a0994

• Toggle is-rotating class

  swissspidy

  committed
  d6c2999

• Some improvements to RotatableBox component

  swissspidy

  committed
  272de08

• Some a11y improvements

  swissspidy

  committed
  9e75944

Commits on Mar 26, 2019

• Don’t setAttributes onRotateStart

  swissspidy

  committed
  8114704

• Use proper Button component

  swissspidy

  committed
  ee69ee9

• Use 0 as initial angle when starting rotating

  Show description for 73c711c
  swissspidy

  committed
  73c711c

• Further UX improvements with rotating

  swissspidy

  committed
  4b79613

Commits on Mar 28, 2019

• Use Math.ceil instead of parseInt

  swissspidy

  committed
  a1cba08

• Merge remote-tracking branch 'origin/amp-stories-redux' into amp-story/2005-rotation

  swissspidy

  committed
  b211b35

• Merge branch 'amp-stories-redux' into amp-story/2005-rotation

  swissspidy

  committed
  826ddba

Commits on Apr 1, 2019

• Merge branch 'amp-stories-redux' into amp-story/2005-rotation

  swissspidy

  committed
  a83c1c5

• Merge branch 'amp-stories-redux' into amp-story/2005-rotation

  swissspidy

  committed
  c78b7ac

Commits on Apr 2, 2019

• Merge branch 'amp-stories-redux' into amp-story/2005-rotation

  swissspidy

  committed
  abe8595

• First pass at removing jankiness

  swissspidy

  committed
  7130980

• Properly reset angle upon cancel

  swissspidy

  committed
  396680b

• Rename prop for consistency with BlockMover

  swissspidy

  committed
  10009c9

Commits on Apr 8, 2019

• Merge branch 'amp-stories-redux' into amp-story/2005-rotation

  swissspidy

  committed
  5ac6eda

Commits on Apr 9, 2019

• Merge branch 'amp-stories-redux' into amp-story/2005-rotation

  swissspidy

  committed
  93e1963

Commits on Apr 10, 2019

• Merge branch 'amp-stories-redux' into amp-story/2005-rotation

  swissspidy

  committed
  bb20a0c

• Clear selected block after rotation to make result immediately visible

  swissspidy

  committed
  71371ab

• Improve block mover styles by removing box-shadows

  swissspidy

  committed
  c439269

• Fix isFirst / isLast handling in block mover

  swissspidy

  committed
  3f6b848

• Hide default block mover to show ours instead

  swissspidy

  committed
  252a0dc

• Hide rotation controls while dragging clone

  swissspidy

  committed
  d5bca67

• Simplify code / fix lint issues

  swissspidy

  committed
  f158fda

Commits on Apr 11, 2019

• Remove now obsolete actions

  swissspidy

  committed
  8671c60

• Clarify check for right click

  swissspidy

  committed
  4d6c685

• Limit angles when rotating via arrow keys

  swissspidy

  committed
  5e43f0d