Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing amp-install-serviceworker script in classic mode #2074

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Add missing amp-install-serviceworker script in classic mode #2074

merged 1 commit into from
Apr 5, 2019

Conversation

westonruter
Copy link
Member

Amends #1261.

Before:

image

After:

image

@westonruter westonruter added this to the v1.1 milestone Apr 5, 2019
@westonruter westonruter requested a review from amedina April 5, 2019 20:39
@googlebot googlebot added the cla: yes Signed the Google CLA label Apr 5, 2019
amedina
amedina approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@amedina
Copy link
Member

amedina commented Apr 5, 2019

Love to see this integration taking place.

@westonruter westonruter merged commit 9246809 into develop Apr 5, 2019
@westonruter westonruter deleted the fix/classic-mode-sw-integration branch April 5, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amedina amedina amedina approved these changes

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@westonruter @amedina @googlebot