Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dragging after resizing / rotation #2352

Merged
merged 4 commits into from
May 21, 2019

Conversation

miina
Copy link
Contributor

@miina miina commented May 20, 2019

Fixes #2306.

Note that this issue happened for all the blocks, not just the image block.

@googlebot googlebot added the cla: yes Signed the Google CLA label May 20, 2019
@miina miina marked this pull request as ready for review May 21, 2019 09:36
@miina miina requested a review from swissspidy May 21, 2019 09:36
@swissspidy
Copy link
Collaborator

@miina I see that this keeps block selection after resizing and rotating, but how does this fix #2306?

@miina
Copy link
Contributor Author

miina commented May 21, 2019

@swissspidy The block gets deselected and the editor unfocused after rotating/resizing so that the user needs to click anywhere on the editor again for being able to drag again.

This PR forces the selection of the block that was resized / rotated so that the user wouldn't need to select anything.

This is before:
May-21-2019 12-12-44

This is after:
May-21-2019 12-16-10

Are you seeing something different?

@swissspidy
Copy link
Collaborator

Ah I see. In that case it's weird that the block mover was shown for a non-selected block in the first place when it's not working 🤷‍♂

@swissspidy swissspidy merged commit a748160 into amp-stories-redux May 21, 2019
@westonruter westonruter added this to the v1.2 milestone May 21, 2019
@swissspidy swissspidy deleted the amp-story/2306-fix_dragging branch June 18, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants