Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated formattingControls. #2919

Merged
merged 4 commits into from
Aug 1, 2019
Merged

Remove deprecated formattingControls. #2919

merged 4 commits into from
Aug 1, 2019

Conversation

miina
Copy link
Contributor

@miina miina commented Jul 30, 2019 •
edited
Loading

formattingControls will be deprecated with WordPress/gutenberg#14542.

This PR updates the code in CTA block to match that.

Updates style for Inline Code and removes the deprecated param.

@googlebot googlebot added the cla: yes Signed the Google CLA label Jul 30, 2019
@miina miina requested a review from kienstra July 31, 2019 18:21
@miina miina marked this pull request as ready for review July 31, 2019 18:22
@kienstra
Copy link
Contributor

Approved

Hi @miina,
Good idea to remove the formattingControls, with their deprecation in Gutenberg that you mentioned.

This PR looks good.

@miina miina merged commit 5b5440b into develop Aug 1, 2019
@miina miina deleted the fix/remove-deprecated-param branch August 1, 2019 09:36
@swissspidy swissspidy added this to the v1.2.1 milestone Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy left review comments

@kienstra kienstra kienstra approved these changes

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@miina @kienstra @swissspidy @googlebot