Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint-plugin-jest and apply fixes #3192

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Update eslint-plugin-jest and apply fixes #3192

merged 1 commit into from
Sep 6, 2019

Conversation

swissspidy
Copy link
Collaborator

Supersedes #3191

@swissspidy swissspidy added the Infrastructure Changes impacting testing infrastructure or build tooling label Sep 5, 2019
@swissspidy swissspidy added this to the v1.3 milestone Sep 5, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Sep 5, 2019
@swissspidy swissspidy added the Enhancement New feature or improvement of an existing one label Sep 5, 2019
spacedmonkey
spacedmonkey approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swissspidy swissspidy merged commit 95d85a7 into develop Sep 6, 2019
@swissspidy swissspidy deleted the update/eslint-plugin-jest branch September 6, 2019 15:00
westonruter added a commit that referenced this pull request Sep 10, 2019
@westonruter
Merge branch 'develop' of github.com:ampproject/amp-wp into add/dev-m…
58f5eb3 
…ode-support

* 'develop' of github.com:ampproject/amp-wp: (28 commits)
  Exclude development files from production build ZIPs
  Add filter to allow more video types in AMP story background se… (#3171)
  Update dependency @babel/cli to v7.6.0 (#3203)
  Update dependency @babel/core to v7.6.0 (#3204)
  Remove deprecated AMP_WP_Utils class
  Refresh Composer lock file
  Run build in a temporary folder
  Add shell script to clean up the current folder and then trigger a build
  Adapt Gruntfile to fetch optimized Composer dependencies within the build folder
  Retrieve Sabberworm patch directly from the GitHub PR
  Adding regression test for vertical text alignment issues
  Fixing minor errors in test descriptions
  Only restrict height inside non-fit text blocks
  Rewritten block size tests
  Limit height declaration to only direct descendant
  Remove now obsolete withEnforcedVideoUploadType HOC
  Update eslint-plugin-jest and apply fixes (#3192)
  Update dependency postcss to v7.0.18 (#3200)
  Update dependency terser-webpack-plugin to v2 (#3195)
  Update dependency webpack-cli to v3.3.8 (#3194)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey spacedmonkey approved these changes

@dero dero Awaiting requested review from dero

@barklund barklund Awaiting requested review from barklund

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA Enhancement New feature or improvement of an existing one Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@swissspidy @spacedmonkey @googlebot