Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle cut keyboard requests. #3231

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Handle cut keyboard requests. #3231

merged 1 commit into from
Sep 12, 2019

Conversation

spacedmonkey
Copy link
Contributor

@spacedmonkey spacedmonkey added Bug Something isn't working [AMP Stories] Editing labels Sep 12, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Sep 12, 2019
@swissspidy swissspidy merged commit 7ba9f26 into develop Sep 12, 2019
@swissspidy swissspidy deleted the fix/on-cut-handler branch September 12, 2019 17:42
@spacedmonkey spacedmonkey mentioned this pull request Sep 12, 2019
Closed
westonruter added a commit that referenced this pull request Sep 14, 2019
@westonruter
Merge branch 'develop' of github.com:ampproject/amp-wp into fix/3137-…
9b52059 
…keep-attributes-with-mustache-placeholders-intact

* 'develop' of github.com:ampproject/amp-wp: (113 commits)
  This converts the keyboard cut handler to equal a copy handler to avoid bugs
  Fix aria-label adding helper function
  Remove extra line I added in resolving merge conflict
  Fix alignment of arrow
  Fix custom CTA text for page attachment
  Fix cut handler by shortcut
  Cleanup of duplicated comment
  Add unit testing to `addVideoAriaLabel`
  Remove unused piece of code
  Remove Cloudflare AMP cache since deprecated
  Handle cut keyboard requests. (#3231)
  Page Attachment block (#3035)
  Keyboard & Right-Click Menu Copy + Paste (#3083)
  Animation Previews (#3104)
  Make internal methods inaccessible
  Omit the ecosystem link also when using a core theme
  Add skipped e2e test for the video block
  Add array_colum() pollyfill for PHP < 5.5
  Add asserts to make sure we are not enqueueing both versions of dashicons
  Remove useless variable
  ...
@westonruter westonruter added this to the v1.3 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@dero dero Awaiting requested review from dero

@barklund barklund Awaiting requested review from barklund

Assignees
No one assigned
Labels
Bug Something isn't working cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Right-Click: Add options to cut/copy/paste blocks
4 participants
@spacedmonkey @swissspidy @westonruter @googlebot