Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce keyboard cut handler to equal a copy handler to avoid bugs #3241

Merged
merged 2 commits into from
Sep 13, 2019

Conversation

barklund
Copy link
Contributor

Fixes #2989.

With this change, using the keyboard to cut a block, nothing visually happens, but the selected block is actually copied. Users can still right-click cut the block if they want.

This must be fixed in a future ticket. See inline todo for a description of the issue.

…id bugs

Fixes #2989.

With this change, using the keyboard to cut a block, nothing visually happens, but the selected block is actually copied. Users can still right-click cut the block if they want.

This must be fixed in a future ticket. See inline `todo` for a description of the issue.
@barklund barklund added Bug Something isn't working AMP Stories labels Sep 13, 2019
@barklund barklund added this to the v1.3 milestone Sep 13, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Sep 13, 2019
Copy link
Contributor

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@westonruter westonruter merged commit da5c94a into develop Sep 13, 2019
@westonruter westonruter deleted the fix/2989-revert-to-least-critical-bug branch September 13, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right-Click: Add options to cut/copy/paste blocks
4 participants