Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caption support to the Gallery block in <amp-carousel> and fix displaying Gallery block as carousel in WP 5.3 #3285

Merged
merged 16 commits into from
Oct 28, 2019
Merged

Add caption support to the Gallery block in <amp-carousel> and fix displaying Gallery block as carousel in WP 5.3 #3285

merged 16 commits into from
Oct 28, 2019

Commits on Sep 17, 2019

  1. Add caption support to the Gallery shortcode and block in <amp-carousel> 

    For images in a gallery that have a caption,
display them when in an <amp-carousel>.
    @kienstra
    kienstra committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    2fab3b9 View commit details
    Browse the repository at this point in the history

  2. Add a 'scrim' at the bottom of the carousel, using amp.dev as an exam… 

    …ple.
    @kienstra
    kienstra committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    0b0b2fd View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. Merge branch 'develop' into add/gallery-caption

    @kienstra
    kienstra committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    c5f0040 View commit details
    Browse the repository at this point in the history

  2. Revert "Add a 'scrim' at the bottom of the carousel, using amp.dev as… 

    … an example."

This reverts commit 0b0b2fd.
    @kienstra
    kienstra committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    a6fec8c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Merge branch 'develop' into add/gallery-caption

    @kienstra
    kienstra committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    af5b86d View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. Taking cues from the Newspack Carousel, improve captions 

    It looks like this is working well with the Core themes
Twenty Fifteen through Twenty Nineteen.
    @kienstra
    kienstra committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    f034593 View commit details
    Browse the repository at this point in the history

  2. Attempt to fix failed PHPUnit tests in PHP 5.5 

    Instead of modifying the ->textContent property,
create a new text node,
and append it to the <span> node.
    @kienstra
    kienstra committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    e52a3ea View commit details
    Browse the repository at this point in the history

  3. Rename $div to $slide, as it's more descriptive 

    It's actually a slide in the <amp-carousel>
Also, add a comment, and remove an extra newline.
    @kienstra
    kienstra committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    19d8af7 View commit details
    Browse the repository at this point in the history

  4. Move position: absolute to the top of the style rules 

    This is more important than
text-align: center.
    @kienstra
    kienstra committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    d4dd0a3 View commit details
    Browse the repository at this point in the history

  5. Fix gallery carousel in the latest Gutenberg (and WP 5.3)

    @westonruter
    westonruter committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    03adbd9 View commit details
    Browse the repository at this point in the history

  6. Prevent rendering wp-block-gallery with display:flex

    @westonruter
    westonruter committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    a202971 View commit details
    Browse the repository at this point in the history

  7. Address CSS linting issue 

    assets/css/src/amp-default.css
 76:37  ✖  Expected double quotes   string-quotes
Simply change the ' to ".
    @kienstra
    kienstra committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    e8ffb78 View commit details
    Browse the repository at this point in the history

  8. Account for galleries that only have a lightbox 

    In that case, I think the sanitizer
should still run.
This could still use more testing.
    @kienstra
    kienstra committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    7f7f5ca View commit details
    Browse the repository at this point in the history

  9. Refactor the contains() query with Weston's suggestion 

    Though maybe this isn't applied
as intended.
    @kienstra
    kienstra committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    9af22c8 View commit details
    Browse the repository at this point in the history

  10. Add a trailing comma to address a phpcs issue.

    @kienstra
    kienstra committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    a19b89a View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. Merge branch 'develop' into add/gallery-caption

    @kienstra
    kienstra committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    0f0fd39 View commit details
    Browse the repository at this point in the history