Remove unused Travis deploy stage #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The file Also, this cache folder referenced in Line 25 in 0c627dc |
|
Good catch. Fixed in 1cc08e0. |
schlessera
approved these changes
Sep 24, 2019
|
Seems good to go! |
|
Failed due to unrelated E2E test failure, so merging anyway. |
westonruter
added a commit
that referenced
this pull request
Sep 24, 2019
* Remove unused Travis deploy stage * Remove obsolete bin/deploy-travis-pantheon.sh and deployment-targets cache
westonruter
added a commit
that referenced
this pull request
Oct 1, 2019
* tag '1.3.0': (318 commits) Bump 1.3.0 Add inline styles for custom fonts (#3345) Limit deeply-nesting test to 200 to fix Xdebug error (#3341) Bump 1.3-RC2 (#3335) Sanitize invalid children of amp-story and amp-story-page elements to prevent white story of death (#3336) Remove unused Travis deploy stage (#3340) Implement automated accessibility testing using Axe (#3294) Only add all Google Font style rules in editor context Prevent adding AMP query var to Story URLs in Compatibility Tool Prevent attempting to redirect Stories with rejected validation errors Ensure all AMP scripts (including v0.js) get moved to the head Make sure that media picker is background types are filter correctly. Normalize style[type] attribute quote style after r46164 in WP core Fix phpunit covers tags Bump version to 1.3-RC1 Strip 100% width/height from layout=fill elements Fix issue with cut (#3246) Remove unused Google Fonts SVGs (#3289) Fix resize for non-fit text box (#3259) Use template_dir consistently as signal for transitional mode ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently not using the
ampconfdemoenvironment for testing, which is what the currentdeploystage is targeting. In any case, the limit of multidev environments on that site has been overrun doing deploys when pushing to the 1.3 branch currently causes a failure:So we should just eliminate the
deploystage and re-focus on getting automatic deployments to a testing environment set up. See #1840, #2084.