Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate height, width & layout attributes #3728

Merged
merged 40 commits into from
Dec 30, 2019
Merged

Validate height, width & layout attributes #3728

merged 40 commits into from
Dec 30, 2019

Commits on Dec 21, 2019

  1. Validate height, width & layout attributes

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    3bf75cc View commit details
    Browse the repository at this point in the history

  2. Convert docblocks to multi-line comments

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    f5265de View commit details
    Browse the repository at this point in the history

  3. Use stricter checking for undefined attributes

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    a585fb1 View commit details
    Browse the repository at this point in the history

  4. Refactor code for PHP 5.4+ compatibility

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    855a3c8 View commit details
    Browse the repository at this point in the history

  5. Add tests to cover some edge cases

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    a5aa7d6 View commit details
    Browse the repository at this point in the history

  6. Add a reference and link to the JS code that the code was adapted fro… 

    …m, and at which version
    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    a43f046 View commit details
    Browse the repository at this point in the history

  7. Assert the element has the amp_layout spec before validating the la… 

    …yout
    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    4ef85d0 View commit details
    Browse the repository at this point in the history

  8. Correct description of determining a valid responsive layout

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    cb312b6 View commit details
    Browse the repository at this point in the history

  9. Typehint AMP_CSS_Length function parameters

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    298c5cc View commit details
    Browse the repository at this point in the history

  10. Adapt width and height to conform to the AMP layout

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    8af168c View commit details
    Browse the repository at this point in the history

  11. Refactor conditions for testing layout validation logic

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    fca36cb View commit details
    Browse the repository at this point in the history

  12. Refactor AMP_CSS_Length

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    c7c271a View commit details
    Browse the repository at this point in the history

  13. Add more tests for fill layout

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    eac33b7 View commit details
    Browse the repository at this point in the history

  14. Update amp_is_attribute_empty doc comment

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    bed6d28 View commit details
    Browse the repository at this point in the history

  15. Set layout attribute if data-amp-layout attribute exists

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    2aa4b00 View commit details
    Browse the repository at this point in the history

  16. Add AMP_Layout_Sanitizer to sanitize elements with layout or `dat… 

    …a-amp layout` attribute
    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    713fec6 View commit details
    Browse the repository at this point in the history

  17. Validate layout before sanitizing attributes

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    9ebe64b View commit details
    Browse the repository at this point in the history

  18. Remove amp_is_attribute_empty function

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    462d598 View commit details
    Browse the repository at this point in the history

  19. Query only for elements with a width or height attribute

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    4838f18 View commit details
    Browse the repository at this point in the history

  20. Add tests

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    c6dafea View commit details
    Browse the repository at this point in the history

  21. Ignore elements with layout attribute

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    5fc94fb View commit details
    Browse the repository at this point in the history

  22. Use valid AMP markup for tests

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    943e86b View commit details
    Browse the repository at this point in the history

  23. Set facebook embed layout via data-amp-layout to allow layout sanit… 

    …izer to fix potential issues
    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    b9b2fa1 View commit details
    Browse the repository at this point in the history

  24. Make checking for an empty attribute DRY

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    87043f8 View commit details
    Browse the repository at this point in the history

  25. Apply fill layout when the width & height are set to 100% in style … 

    …attribute
    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    c2fe40d View commit details
    Browse the repository at this point in the history

  26. Fix PHPCS issues

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    4f9a6e2 View commit details
    Browse the repository at this point in the history

  27. Reapply style attribute if there are any descriptors left

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    75e9892 View commit details
    Browse the repository at this point in the history

  28. Unabbreviate attr_empty

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    c152cf9 View commit details
    Browse the repository at this point in the history

  29. Fix grammatical errors in comments

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    05fbcbf View commit details
    Browse the repository at this point in the history

  30. Remove HTML markup in docblocks

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    c015993 View commit details
    Browse the repository at this point in the history

  31. Add test for verifying style attribute being maintained when setting … 

    …layout
    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    677d26e View commit details
    Browse the repository at this point in the history

  32. Accommodate for a 100% width or height being defined as style descrip… 

    …tor or via its attribute
    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    106d0cf View commit details
    Browse the repository at this point in the history

  33. Use error codes to identify the invalid layout detected

    @pierlon
    pierlon committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    2c3bfe5 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2019

  1. Make video in cover block fill the container

    @westonruter
    westonruter committed Dec 28, 2019
    Configuration menu
    Copy the full SHA
    379f634 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2019

  1. Add tests for getting dimensions of local video; clean up uploaded files

    @westonruter
    westonruter committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    0e724d1 View commit details
    Browse the repository at this point in the history

  2. Fix handling of elements with width/height set to 100%

    @westonruter
    westonruter committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    99c7b4a View commit details
    Browse the repository at this point in the history

  3. Avoid use of WP_Error for representing validation error 

    * Improve method name.
* Add test for Facebook embed that has supplied height.
* Improve phpdoc.
    @westonruter
    westonruter committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    51a5536 View commit details
    Browse the repository at this point in the history

  4. Use constants for error codes

    @westonruter
    westonruter committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    706674d View commit details
    Browse the repository at this point in the history

  5. Add test for invalid heights attribute

    @westonruter
    westonruter committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    b27341e View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2019

  1. Swap PHP 5.4 for 5.6 to run external-http tests

    @westonruter
    westonruter committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    e42411f View commit details
    Browse the repository at this point in the history