Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds (de-)activation function. #39

Merged
merged 1 commit into from
Oct 8, 2015
Merged

Adds (de-)activation function. #39

merged 1 commit into from
Oct 8, 2015

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Oct 8, 2015

  • Flush the rewrite rules to remove the currently required manual step.
  • Created separate functions for activation and deactivation for future needs. Could be one function for now.

Fixes #29

@kraftbj
Adds (De-)activation function.
c7053b3 
* Flush the rewrite rules to remove the currently required manual step.
* Created separate functions for activation and deactivation for future needs. Could be one function for now.
@kraftbj kraftbj added the Enhancement New feature or improvement of an existing one label Oct 8, 2015
@mjangda
Copy link
Contributor

mjangda commented Oct 8, 2015

Nice!

(Build failure is due to fatals from the wordpress-test-lib; REST API merges are going on and breaking stuff :))

mjangda added a commit that referenced this pull request Oct 8, 2015
@mjangda
Merge pull request #39 from Automattic/add/auto-rewrite-flush
00c8f75 
Adds (de-)activation function.
@mjangda mjangda merged commit 00c8f75 into master Oct 8, 2015
@mjangda mjangda deleted the add/auto-rewrite-flush branch October 8, 2015 03:20
@badfeather badfeather mentioned this pull request Oct 24, 2016
Closed
kienstra pushed a commit that referenced this pull request Jan 22, 2018
Issue #864: Only add AMP widget support if is_amp_endpoint().
74d727b 
I had tried to wrap the action hook in this conditional:
add_action( 'init', 'amp_add_widget_support' )
But this produced this notice:
is_amp_endpoint was called <strong>incorrectly</strong>.
 is_amp_endpoint() was called before the &#39;parse_query&#39; hook was called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement New feature or improvement of an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraftbj @mjangda