Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wp-dev-lib package #4029

Merged
merged 6 commits into from
Jan 8, 2020
Merged

Update wp-dev-lib package #4029

merged 6 commits into from
Jan 8, 2020

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Jan 7, 2020

See: xwp/wp-dev-lib/pull/310

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon requested a review from westonruter January 7, 2020 15:31
@googlebot googlebot added the cla: yes Signed the Google CLA label Jan 7, 2020
westonruter
westonruter requested changes Jan 7, 2020
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about composer.lock?

@pierlon
Copy link
Contributor Author

pierlon commented Jan 7, 2020

Ah wait a minute, pushing an updated composer.lock.

@swissspidy
Copy link
Collaborator

Is this change worth it? Core has just fixed this for trunk: https://core.trac.wordpress.org/changeset/47048

@swissspidy
Copy link
Collaborator

There's some unrelated lint error now 🤔

FILE: tests/php/test-class-amp-imgur-embed-handler.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 34 | ERROR | [x] Line indented incorrectly; expected at least 5 tabs, found
    |       |     4 (Generic.WhiteSpace.ScopeIndent.Incorrect)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

@pierlon
Copy link
Contributor Author

pierlon commented Jan 7, 2020

Is this change worth it?

Glad to see its fixed in Core. This package update would include the wp-includes folder from WP Core SVN which also includes the built block-library asset files, for example, so a win nonetheless.

@pierlon pierlon changed the title Update wp-dev-lib package to fix Travis errors Update wp-dev-lib package Jan 7, 2020
@swissspidy swissspidy requested a review from westonruter January 7, 2020 15:54
@pierlon
Copy link
Contributor Author

pierlon commented Jan 7, 2020

Reverted change from #3847 as the fix is now made upstream.

@westonruter westonruter added this to the v1.4.3 milestone Jan 7, 2020
westonruter
westonruter approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: to be squash-merged to facilitate cherry-picking onto the 1.4 branch.

@swissspidy swissspidy mentioned this pull request Jan 7, 2020
Closed
1 task
@westonruter
Copy link
Member

The test_prioritized_stylesheets test is failing in WordPress 5.0 and 5.1.

@westonruter westonruter mentioned this pull request Jan 8, 2020
Closed
1 task
@westonruter westonruter merged commit 79e9d75 into develop Jan 8, 2020
@westonruter westonruter deleted the fix/travis-missing-wp-assets-folder branch January 8, 2020 22:57
westonruter pushed a commit that referenced this pull request Jan 8, 2020
@pierlon @westonruter
Update wp-dev-lib package (#4029)
34f3c83 
* Update wp-dev-lib package to fix Travis errors

See: xwp/wp-dev-lib#310

* Update composer.lock

* Make phpcs happy

* Revert "Pull the built `block-libray` package from Gutenberg SVN if it does not exists (#3847)"

This reverts commit 12c1d47

* Revert update of indirect packages

* Update wp-dev-lib to 1.3.2
@swissspidy swissspidy mentioned this pull request Jan 9, 2020
Merged
3 tasks
westonruter added a commit to xwp/amp-wp that referenced this pull request Jan 10, 2020
@westonruter
Merge branch 'develop' of github.com:ampproject/amp-wp into add/spa-a…
8caa8db 
…mp-shadow-dom-updated

* 'develop' of github.com:ampproject/amp-wp: (233 commits)
  Ignore Story editor tests (ampproject#4043)
  Update dependency eslint-plugin-jest to v23.4.0 (ampproject#4056)
  Update dependency xwp/wp-dev-lib to v1.4.0
  Update amp-video embed regex pattern to include other Vimeo URL formats (ampproject#4051)
  Update amp-instagram embed regex (ampproject#4053)
  Update dependency terser-webpack-plugin to v2.3.2 (ampproject#4047)
  Fix ability to update the status of a validation error
  Update wp-dev-lib package (ampproject#4029)
  Update dependency core-js to v3.6.2 (ampproject#4028)
  Update dependency @wordpress/element to v2.10.0 (ampproject#3986)
  Update dependency browserslist to v4.8.3 (ampproject#4021)
  Update dependency grunt-http to v2.3.3 (ampproject#4022)
  Update dependency postcss to v7.0.26 (ampproject#4017)
  Update dependency eslint-utils to v2 (ampproject#4012)
  Update dependency eslint-plugin-jest to v23.3.0 (ampproject#4016)
  Update dependency css-loader to v3.4.1 (ampproject#4023)
  Update dependency webpack to v4.41.5 (ampproject#4014)
  Update dependency core-js to v3.6.1 (ampproject#4011)
  Update dependency eslint to v6.8.0 (ampproject#4002)
  Swap PHP 5.4 for 5.6 to run external-http tests
  ...
westonruter added a commit that referenced this pull request Feb 13, 2020
@westonruter
Merge tag '1.4.3'
06162df 
* tag '1.4.3': (22 commits)
  Update readme and screenshots for Stories removal (#4259)
  Open story export instructions in a new window (#4258)
  Bump version to 1.4.3-RC1
  Hide Stories options and add deprecation notice (#4219)
  Fix malformed conversion of relative action URLs for forms (#4250)
  Limit Stories experience to WP 5.3 & Gutenberg 7.1.0 (#4217)
  Prevent errors in admin bar filters from non-array arguments (#4207)
  Update @wordpress/e2e-test-utils dependency
  Revert update of mustache/mustache dependency
  Update composer.lock
  Update WP CLI to 2.4.0
  For WordPress.tv embed, Use an oembed filter instead of block filter (#4164)
  Update readme to add FAQs section (#4159)
  Apply workaround to fix test__multiple_valid_image_files (#4034)
  Ignore Story editor tests (#4043)
  Update amp-video embed regex pattern to include other Vimeo URL formats (#4051)
  Update amp-instagram embed regex (#4053)
  Update wp-dev-lib package (#4029)
  Fix conversion of forms with relative action URLs (#4003)
  Improve release instructions (#3995)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@pierlon @swissspidy @westonruter @googlebot