Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery: simple draft of the masks system #4062

Closed
wants to merge 1 commit into from

Conversation

dvoytenko
Copy link

@dvoytenko dvoytenko commented Jan 11, 2020

Summary

No issue available yet. In design phase. But PR is meant to instruct some technicals.

Some implementation nuances:

  1. The mask is applied to all elements in the display mode, right in between the Wrapper and the Display.
  2. The Edit mode is different and the elements are expected to apply the mask themselves. This is because the edit mode is pretty nuanced and requires different specialized layouts.
  3. The Wrapper is set to pointer-events: none. This is so that clicking within the total rectangle but outside the max (see the "heart" in the demo), the content seen behind the mask is selected.
  4. The nuances of editing the mask on the right side (or any other) is still WIP by @samitron7, so this is a very preliminary debugging stuff.

See demo:
ezgif-5-9d0358b6baf8

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Jan 11, 2020
@swissspidy swissspidy added the Stories Stories Editor label Jan 13, 2020
@pbakaus
Copy link

pbakaus commented Jan 14, 2020

This is super cool!

@miina
Copy link
Contributor

miina commented Jan 14, 2020

Looks cool indeed!

Would be great if you could also implement one example for saving the mask into DB for the FE display for the purposes of PoC.

@dvoytenko
Copy link
Author

@miina Yes. This is very "draft" version. Just wanted to first confirm some editor/format nuances first. LMK if you have any more comments. I'm working on the FE part.

@miina
Copy link
Contributor

miina commented Jan 15, 2020

@miina Yes. This is very "draft" version. Just wanted to first confirm some editor/format nuances first. LMK if you have any more comments. I'm working on the FE part.

Sure, understood that this is a very draft version, was just interested in seeing the draft version of FE as well, no rush intended at all! The editor part looks good so far.

@swissspidy
Copy link
Collaborator

swissspidy commented Feb 13, 2020

Closing in favor of GoogleForCreators/web-stories-wp#246

@swissspidy swissspidy closed this Feb 13, 2020
@swissspidy swissspidy deleted the try/masks branch February 13, 2020 12:57
@swissspidy swissspidy added AMP Stories (obsolete) and removed Stories Stories Editor labels Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants