Avoid entering The Loop when rendering Reader template #4185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue that was uncovered by @jackmcconnell in #1780 (comment).
If an overridden Reader mode template attempted to use The Loop to render the title or content, for example:
This would result in nothing being output because
reader-template-loader.php
was entering The Loop viathe_post()
. Since only one post is in The Loop in singular queries, the result was thathave_posts()
would returnfalse
and nothing would be output.The fix is simply to directly populate the
$post
global and set up its global variables without advancing thecurrent_post
in the globalWP_Query
.This fixes a regression that was introduced in #3781.
Checklist