Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally remove html[xmlns], convert html[xml:lang] to html[lang] #4194

Merged
merged 6 commits into from
Jan 30, 2020
Merged

Conditionally remove html[xmlns], convert html[xml:lang] to html[lang] #4194

merged 6 commits into from
Jan 30, 2020

Commits on Jan 29, 2020

  1. Conditionally remove html[xmlns], and convert html[xml:lang] to html[… 

    …lang]

As Weston mentioned,
neither of these is valid HTML5
    @kienstra
    kienstra committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    d6faeb4 View commit details
    Browse the repository at this point in the history

  2. If the html[lang] is "", overwrite it with the xml:lang 

    Before, if the xml:lang was non-empty and the lang was "",
this would not overwrite it.
    @kienstra
    kienstra committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    93d96f4 View commit details
    Browse the repository at this point in the history

  3. Use $html->hasAttributes to possibly exit early.

    @kienstra
    kienstra committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    ff6bdba View commit details
    Browse the repository at this point in the history

  4. Commit Weston's suggestion to use documentElement 

    Co-Authored-By: Weston Ruter <westonruter@google.com>
    @kienstra @westonruter
    kienstra and westonruter authored Jan 29, 2020
    Configuration menu
    Copy the full SHA
    7aaf8fd View commit details
    Browse the repository at this point in the history

  5. Fix PHPCS error

    @kienstra
    kienstra committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    aa49504 View commit details
    Browse the repository at this point in the history

  6. Remove needless $xmlns_value_to_strip variable 

    As Weston mentioned, this is only used
in one place an shouldn't be needed.
    @kienstra
    kienstra committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    096cf7b View commit details
    Browse the repository at this point in the history