Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require unreleased version of PHP-CSS-Parser #4300

Merged
merged 6 commits into from
Feb 19, 2020
Merged

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Feb 16, 2020

Summary

This PR updates the version of PHP-CSS-Parser to the commit MyIntervals/PHP-CSS-Parser@134f4e6, instead of the latest release version 8.3.0. The commit aforementioned includes a fix that would resolve #4197.

A patch is also included for PHP-CSS-Parser to fix the validation of selectors, namely adding ,, \ and @ as valid characters.

Also, I've used the undocumented flag no-api to instruct Composer to retrieve the repository via Git instead of using the GitHub API, due to a rate limit on their API that usually occurs when composer update is run. The alternative to not using no-api is giving Composer your GitHub credentials or creating a GitHub OAuth token, as described here.

Fixes #4197.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Feb 16, 2020
@pierlon pierlon marked this pull request as ready for review February 16, 2020 06:40
@westonruter
Copy link
Member

Could you include a test for what is being fixed?

@pierlon
Copy link
Contributor Author

pierlon commented Feb 16, 2020

Done!

@westonruter
Copy link
Member

Looks good to me but @schlessera would probably have more to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semicolon at end of declaration block in media query produces invalid CSS
3 participants