-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent removal of closing table
and td
tags in script[template="amp-mustache"]
#4333
Commits on Feb 25, 2020
-
Use Weston's snippet to correct ensure the amp-mustache template's ou…
…tput Now, it doesn't have </table> stripped, or the closing </td>.
Configuration menu - View commit details
-
Copy full SHA for 826a430 - Browse repository at this point
Copy the full SHA 826a430View commit details -
Add a test for script[amp-mustache] with 3 child nodes
As Weston suggested, to prevent regressions.
Configuration menu - View commit details
-
Copy full SHA for 5ef39b7 - Browse repository at this point
Copy the full SHA 5ef39b7View commit details -
Change regex to accept single or no quote, add test
Weston mentioned that this could have single or no quotes. I hadn't thought of that.
Configuration menu - View commit details
-
Copy full SHA for 83d3dd6 - Browse repository at this point
Copy the full SHA 83d3dd6View commit details
Commits on Mar 2, 2020
-
Improve regex, based on Alain's suggestions
Allow spaces in the closing </script>, like </script > Also, make this case-insensitive and ensure the quotes types are the same.
Configuration menu - View commit details
-
Copy full SHA for 52d49e9 - Browse repository at this point
Copy the full SHA 52d49e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65a16ef - Browse repository at this point
Copy the full SHA 65a16efView commit details
Commits on Mar 9, 2020
-
Merge in develop, resolve conflicts
The conflicts were deleted files: src/Dom/Document.php tests/php/test-class-amp-dom-document.php This simply moves the changes in those files to the relevant new files.
Configuration menu - View commit details
-
Copy full SHA for a1d8469 - Browse repository at this point
Copy the full SHA a1d8469View commit details -
Revert "Merge in develop, resolve conflicts"
This reverts commit a1d8469.
Configuration menu - View commit details
-
Copy full SHA for f86eab1 - Browse repository at this point
Copy the full SHA f86eab1View commit details -
Merge in develop, resolve conflicts
The conflicts were deleted files: src/Dom/Document.php tests/php/test-class-amp-dom-document.php This simply moves the changes in those files to the relevant new files.
Configuration menu - View commit details
-
Copy full SHA for 387bd10 - Browse repository at this point
Copy the full SHA 387bd10View commit details -
Correct code styling, mainly removing spaces
Also, correct a function name in a DocBlock tag.
Configuration menu - View commit details
-
Copy full SHA for 19af10d - Browse repository at this point
Copy the full SHA 19af10dView commit details -
Address failed unit tests and PSR-12 coding style
Maybe <script async shouldn't be changed to <script async="" But with how the workaround works, it sets the script attributes to their previous attributes. So <script async will eventually end up as <script async="".
Configuration menu - View commit details
-
Copy full SHA for 2d7bb8a - Browse repository at this point
Copy the full SHA 2d7bb8aView commit details
Commits on Mar 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 673e5a9 - Browse repository at this point
Copy the full SHA 673e5a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73700b9 - Browse repository at this point
Copy the full SHA 73700b9View commit details -
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b74d853 - Browse repository at this point
Copy the full SHA b74d853View commit details