Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent removal of closing table and td tags in script[template="amp-mustache"] #4333

Merged
merged 13 commits into from
Mar 10, 2020

Commits on Feb 25, 2020

  1. Use Weston's snippet to correct ensure the amp-mustache template's ou…

    …tput
    
    Now, it doesn't have </table> stripped,
    or the closing </td>.
    kienstra committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    826a430 View commit details
    Browse the repository at this point in the history
  2. Add a test for script[amp-mustache] with 3 child nodes

    As Weston suggested,
    to prevent regressions.
    kienstra committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    5ef39b7 View commit details
    Browse the repository at this point in the history
  3. Change regex to accept single or no quote, add test

    Weston mentioned that this could have
    single or no quotes.
    I hadn't thought of that.
    kienstra committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    83d3dd6 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. Improve regex, based on Alain's suggestions

    Allow spaces in the closing </script>,
    like </script >
    Also, make this case-insensitive
    and ensure the quotes types are the same.
    kienstra committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    52d49e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65a16ef View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Merge in develop, resolve conflicts

    The conflicts were deleted files:
    src/Dom/Document.php
    tests/php/test-class-amp-dom-document.php
    
    This simply moves the changes in those
    files to the relevant new files.
    kienstra committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    a1d8469 View commit details
    Browse the repository at this point in the history
  2. Revert "Merge in develop, resolve conflicts"

    This reverts commit a1d8469.
    kienstra committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    f86eab1 View commit details
    Browse the repository at this point in the history
  3. Merge in develop, resolve conflicts

    The conflicts were deleted files:
    src/Dom/Document.php
    tests/php/test-class-amp-dom-document.php
    
    This simply moves the changes in those
    files to the relevant new files.
    kienstra committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    387bd10 View commit details
    Browse the repository at this point in the history
  4. Correct code styling, mainly removing spaces

    Also, correct a function name
    in a DocBlock tag.
    kienstra committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    19af10d View commit details
    Browse the repository at this point in the history
  5. Address failed unit tests and PSR-12 coding style

    Maybe <script async shouldn't be changed to
    <script async=""
    But with how the workaround works,
    it sets the script attributes to their previous attributes.
    So <script async
    will eventually end up as <script async="".
    kienstra committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    2d7bb8a View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Configuration menu
    Copy the full SHA
    673e5a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73700b9 View commit details
    Browse the repository at this point in the history
  3. Improve phpdoc descriptions

    Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
    westonruter and schlessera authored Mar 10, 2020
    Configuration menu
    Copy the full SHA
    b74d853 View commit details
    Browse the repository at this point in the history