Fix display of Custom Logo in Twenty Twenty #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
fix/twentytwenty-custom-logo
branch
from
c5da395
to
d59b24a
Compare
kienstra
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Approved
Hi @westonruter,
This looks good. I tested the following Custom Logo dimensions, and they all looked the same in AMP and non-AMP.
120 x 90
1000 x 1000
1600 by 1200
| $mobile_width = $mobile_height * ( $width / $height ); | ||
|
|
||
| $html .= sprintf( | ||
| '<style data-src="%s">.site-logo amp-img { width: %frem; } @media (min-width: 700px) { .site-logo amp-img { width: %frem; } }</style>', |
There was a problem hiding this comment.
Good idea to use %f for float.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4418
Before
After
Checklist