Update selected featured image ID on select #4453
Conversation
|
Build for testing: amp.zip (v1.5.0-RC1-20200327T063343Z-1a4e33c45) |
| id = wp.media.view.settings.post.featuredImageId; | ||
| let attachment; | ||
|
|
||
| if ( '' !== id && -1 !== id ) { |
There was a problem hiding this comment.
If the post type doesn't support featured images, featuredImageId will be undefined here:
even if this code shouldn't load in that case, this should probably include a falsey check as a sanity check.
There was a problem hiding this comment.
Thanks! Made suggested changes in 7cfd2d6.
| @@ -57,47 +56,82 @@ export default ( InitialMediaUpload, minImageDimensions ) => { | |||
| */ | |||
| initFeaturedImage() { | |||
| const FeaturedImageSelectMediaFrame = getSelectMediaFrame( FeaturedImageToolbarSelect ); | |||
|
|
|||
| const FeaturedImageLibrary = wp.media.controller.FeaturedImage.extend( { | |||
There was a problem hiding this comment.
I've extended wp.media.controller.FeaturedImage instead since it already has all the required functionality for updating the featured image ID when being selected, and pushing the selected image to the front of the image collection when being shown in the modal .
| } ), | ||
| ], | ||
| state: 'featured-image', | ||
| states: [ new FeaturedImageLibrary(), new wp.media.controller.EditImage() ], |
There was a problem hiding this comment.
I've added the EditImage controller here to the state since it was a missing feature.
| }); | ||
| }, this.frame ); | ||
|
|
||
| this.frame.on( 'open', this.onOpen ); |
There was a problem hiding this comment.
When the featured image has been changed but not saved, it was not being pushed to the front of the image collection. Hooking into the open event here allows for that to happen.
There was a problem hiding this comment.
@pierlon Can you explain why we need the image pushed to the front of the collection when this happens or what behavior this fixes?
There was a problem hiding this comment.
I guess this is trying to match the core behavior - I see now that it moves the selected item to the top of the list which is nice. It does something funny though if you close the modal with another image selected, then reopen it - the wrong image is moved to the front. Screencast: https://share.getcloudapp.com/12u1n5Yo
Testing with the plugin disabled I see the exact same behavior, so I guess this is fine for now (although it would be great to fix this bug upstream - probably if the user cancels the selection, the original item should be reselected)
There was a problem hiding this comment.
Sorry for the late reply; yes it was to match the behavior of Core.
It does something funny though if you close the modal with another image selected, then reopen it - the wrong image is moved to the front.
Interesting... yes it would be best to have the bug fixed upstream. I'll file an issue in the Gutenberg repo.
|
Fix confirmed by user: #4414 (comment) |
* Update selected featured image ID on select * Add sanity check for featured image ID being possibly undefined * Ensure the featured image is the first item in the collection
|
This is not working for me. If I deactivate the plugin, it works. Activating the plugin (in any mode) makes this feature of WP to go away) |
|
QA: Verified that it works. It did not work without flushing the browser cache. |
* tag '1.5.2': Bump 1.5.2 Bump version to 1.5.1-RC1 Cache response status and headers when fetching external stylesheets (#4509) Fix securing multi-line mustache templates (#4521) Add CSS monitoring time series to Site Health debugging info (#4519) Update hostname used for WordPress TV embeds to fix external HTTP requests (#4524) Fix processing of element child sanitization loop when invalid elements are replaced with children (#4512) Account for more YouTube URL formats (#4508) Update selected featured image ID on select (#4453) Raise default threshold for disabling CSS caching (#4513) Cast i-amphtml-intrinsic-sizer dimensions to integers (#4506) Only move meta tags to the head when required and add processing for meta[http-equiv] (#4505) Fix failing tests (#4507) Bump 1.5.2-alpha
Summary
Set and update the featured image ID so that it can be marked as selected in the Media Library.
Demo
Before
After
Fixes #4414.
Checklist