For the 'Preview AMP' button, replace tooltip with title attribute #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents an issue where the tooltip is cut off.
|
Should this be to the |
kienstra
commented
Apr 17, 2020
| <Button | ||
| className="amp-editor-post-preview" | ||
| href={ href } | ||
| title={ __( 'Preview AMP', 'amp' ) } |
There was a problem hiding this comment.
The label attribute is changed to title.
But other than that, this diff is just from indentation. There's no other change to <Button>
|
Develop branch, yes |
westonruter
pushed a commit
that referenced
this pull request
Apr 17, 2020
Prevents an issue where the tooltip is cut off.
|
Nice, thanks! |
|
Why was this particular tooltip cut off, but all other tooltips in that area work just fine? |
|
Because Gutenberg was using some slot-fill mechanism to locate the tooltip element elsewhere in the DOM so that it could be positioned over the element without other DOM elements overlapping. This wasn't the case for the AMP preview button. |
westonruter
added a commit
that referenced
this pull request
Apr 18, 2020
…phtml-2004041903580 * 'develop' of github.com:ampproject/amp-wp: (48 commits) Bump https-proxy-agent from 2.2.2 to 2.2.4 (#4596) Update dependency babel-jest to v25.3.0 (#4550) Update dependency core-js to v3.6.5 (#4558) For the 'Preview AMP' button, use a title instead of a tooltip (#4601) Bump stable tag to 1.5.3 Fix handling of Mustache templates (#4583) Stub request based on test scenario (#4588) Return early instead of storing eventual return value in variable Improve phpdoc and logic conditions Update links in pull request template Update contributing.md with link to wiki Remove engineering.md now that it is on the wiki Remove project-management.md since only applicable to Stories Add conditions for comment feed, trackback, robots, and favicon Fix typo in global phpdoc Update tests after block-library/style.css changes in Gutenberg 7.9 (#4579) Remove special conditions for Reader mode; remove need for $exit condition in redirects Fix translators comment Add comment explaining short-circuit behavior when query var is present Update version for _doing_it_wrong() from 1.5.3 to 1.6.0 ...
westonruter
added a commit
that referenced
this pull request
Apr 20, 2020
…filter-list-table-row-actions * 'develop' of github.com:ampproject/amp-wp: (56 commits) Bump https-proxy-agent from 2.2.2 to 2.2.4 (#4596) Update dependency babel-jest to v25.3.0 (#4550) Update dependency core-js to v3.6.5 (#4558) For the 'Preview AMP' button, use a title instead of a tooltip (#4601) Update pull request template based on new workflow Bump stable tag to 1.5.3 Fix handling of Mustache templates (#4583) Stub request based on test scenario (#4588) Return early instead of storing eventual return value in variable Improve phpdoc and logic conditions Update links in pull request template Update contributing.md with link to wiki Remove engineering.md now that it is on the wiki Remove project-management.md since only applicable to Stories Add conditions for comment feed, trackback, robots, and favicon Fix typo in global phpdoc Update tests after block-library/style.css changes in Gutenberg 7.9 (#4579) Remove special conditions for Reader mode; remove need for $exit condition in redirects Fix translators comment Add comment explaining short-circuit behavior when query var is present ...
westonruter
added a commit
that referenced
this pull request
Apr 21, 2020
…widgets-registration * 'develop' of github.com:ampproject/amp-wp: (88 commits) Fix grammar typo Bump CSS cache version Update composer.lock Use patch file instead of diff Update patch: Fix parsing CSS selectors which contain commas Update php-css-parser to dev-master#bc6ec74; remove patches/php-css-parser-138-extended.patch Add test to demonstrate failure to parse class names containing escaped fractions Restrict metaboxes which appear on the validated URL screen Update hook priority in test_add_admin_hooks Restrict row actions for taxonomy terms Add test for disable-inline-width on amp-img Exclude data-ampdevmode attribute exclusion rule Update spec to 2004142326360 to remove container layout from amp-list Bump https-proxy-agent from 2.2.2 to 2.2.4 (#4596) Update dependency babel-jest to v25.3.0 (#4550) Update dependency core-js to v3.6.5 (#4558) For the 'Preview AMP' button, use a title instead of a tooltip (#4601) Update pull request template based on new workflow Bump stable tag to 1.5.3 Fix handling of Mustache templates (#4583) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where the tooltip was cut off:
Now, the
<Button>has atitleattribute, instead of being wrapped in a<Tooltip>:Fixes #4590
Checklist