Add input file configuration parsing for spec tests #4662
Conversation
schlessera
added
Optimizer
Testing
| @@ -0,0 +1,2 @@ | |||
| lib/optimizer/resources/local_fallback/* linguist-generated=true | |||
There was a problem hiding this comment.
TIL about using .gitattributes to suppress diffs for generated code (docs) 😄.
Would the path lib/optimiser/ be a better place for this file?
There was a problem hiding this comment.
Yes, that's right. Placing it into lib/optimizer will work, per Git docs:
There was a problem hiding this comment.
As long as GitHub recognizes this, as their docs only mention the repo root.
There was a problem hiding this comment.
I assumed it would only work in the project root, but I can try moving it around to see what happens.
There was a problem hiding this comment.
No, it doesn't work when the .gitattributes file is in a subfolder. I'll revert that change again and leave it in the root for now. This will need to be adapted once we extract the libraries into separate repositories.
Co-authored-by: Weston Ruter <westonruter@google.com>
This reverts commit ef7322c.
* Update spec files * Adapt spec test to extract configuration arguments from input files * Add STYLES configuration key to AmpRuntimeCss transformer * Nake use of styles provided via config if available * Remove runtime style tag if stylesheet is linked * Add more tests to assert runtime transformer behavior * Complete stubbed requests data * Remove unused import * Add git attributes file to mark certain file as being generated * Use substr() instead of a replacement for removing the leading comment * Remove redundant JSONOBJECT_AS_ARRAY constant * Move .gitattributes file into lib/optimizer folder * Revert "Move .gitattributes file into lib/optimizer folder"
Summary
This PR includes the following changes:
amp-toolboxversion.SpecTest.phpto extract the HTML comment with configuration arguments from the input HTML files of the spec test suite.STYLESconfiguration key to theAmpRuntimeCssconfiguration.STYLESconfig argument.<style amp-runtime>element if the stylesheet ended up being linked to.AmpRuntimeCssto ensure configuration arguments behave as expected.StubbedRequestsfiltering from Stub request based on test scenario #4588.gitattributesfile to denote generated files, so that these are collapsed by default in code review.Fixes #4654
Checklist