Suppress Site Health ICU test if site or home URL is not an IDN #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
requested changes
May 13, 2020
pierlon
commented
May 13, 2020
westonruter
reviewed
May 13, 2020
westonruter
reviewed
May 13, 2020
westonruter
approved these changes
May 13, 2020
Make `is_intl_extension_needed()` private Co-authored-by: Weston Ruter <westonruter@google.com>
|
Looks like Travis is broken, merging the |
|
Something seems off here: Why is there no merge commit? |
|
Made an oopsie there, forgot to pull before merging, reverting those commits and pushing the merge commit. |
|
Some Travis jobs are still running so I'll wait for those to complete first. |
pierlon
force-pushed
the
enhancement/4616-hide-icu-site-health-test
branch
from
b4bc5e5
to
d6f0123
Compare
westonruter
added a commit
that referenced
this pull request
May 14, 2020
* Suppress ICU test if site or home URL is not an IDN * Check if any domain labels start with `xn--` to determine if a domain is an IDN * Return true if IDN domain found * Update src/Admin/SiteHealth.php Make `is_intl_extension_needed()` private Co-authored-by: Weston Ruter <westonruter@google.com> Co-authored-by: Weston Ruter <westonruter@google.com>
westonruter
added a commit
that referenced
this pull request
May 15, 2020
…ve-collection-schema-type * 'develop' of github.com:ampproject/amp-wp: Raise PHPStan level to 4 in lib/common (#4686) Update dependency uuid to v8 Update dependency webpack to v4.43.0 Update dependency eslint-plugin-jest to v23.11.0 Update dependency eslint-plugin-react to v7.20.0 (#4691) Update dependency postcss to v7.0.30 (#4649) Update dependency moment to v2.25.3 (#4639) Update dependency babel-jest to v26 (#4652) Update dependency uuid to v7.0.3 (#4490) Update dependency wp-coding-standards/wpcs to v2.3.0 (#4721) Suppress Site Health ICU test if site or home URL is not an IDN (#4698) Pin amp-experiment to v0.1 (#4690) Strip multiple BOM characters (#4683) Strip leading BOM and whitespace and trailing HTML comment before parsing validation response JSON (#4679) Disable share icons Use amp-embedly-card for Tiktok embeds Update dependency xwp/wp-dev-lib to v1.6.4 Update dependency eslint to v7 Update dependency terser-webpack-plugin to v2.3.6
westonruter
added a commit
that referenced
this pull request
May 15, 2020
…-phpstan-to-level-4 * 'develop' of github.com:ampproject/amp-wp: Update dependency @wordpress/scripts to v9.1.0 Update dependency @wordpress/jest-puppeteer-axe to v1.8.0 Update dependency @wordpress/url to v2.15.0 Update dependency @wordpress/plugins to v2.16.0 Raise PHPStan level to 4 in lib/common (#4686) Update dependency uuid to v8 Update dependency webpack to v4.43.0 Update dependency eslint-plugin-jest to v23.11.0 Update dependency eslint-plugin-react to v7.20.0 (#4691) Update dependency postcss to v7.0.30 (#4649) Update dependency moment to v2.25.3 (#4639) Update dependency babel-jest to v26 (#4652) Update dependency uuid to v7.0.3 (#4490) Update dependency wp-coding-standards/wpcs to v2.3.0 (#4721) Update dependency @wordpress/e2e-test-utils to v4.7.0 Suppress Site Health ICU test if site or home URL is not an IDN (#4698) Pin amp-experiment to v0.1 (#4690) Disable share icons Use amp-embedly-card for Tiktok embeds Update dependency terser-webpack-plugin to v2.3.6
|
@pierlon Please specify QA/Testing instructions for this PR/issue. |
|
@amedina I've updated the addressed issue with testing instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4616.
Checklist