Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Optimizer conceptual diagram to README.md file #4840

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Add Optimizer conceptual diagram to README.md file #4840

merged 3 commits into from
Jun 12, 2020

Conversation

schlessera
Copy link
Collaborator

@schlessera schlessera commented Jun 12, 2020 •
edited
Loading

Summary

This PR adds the missing conceptual diagram as an SVG file to the Optimizer's README.md file.

Diagram:

diagram

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Jun 12, 2020
@westonruter westonruter added this to the v1.6 milestone Jun 12, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2020 •
edited
Loading

Plugin builds for 3a89be0 are ready 🛎️!

@schlessera schlessera requested a review from amedina June 12, 2020 22:21
@schlessera
Copy link
Collaborator Author

You can see the page with the diagram here: https://github.com/ampproject/amp-wp/blob/add/optimizer-readme-diagram/lib/optimizer/README.md

(the PR view somehow tries to find the file on the develop branch, don't know why)

@westonruter westonruter merged commit c20c088 into develop Jun 12, 2020
@westonruter westonruter deleted the add/optimizer-readme-diagram branch June 12, 2020 22:25
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 18, 2020
@schlessera schlessera added the WS:Perf Work stream for Metrics, Performance and Optimizer label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@amedina amedina Awaiting requested review from amedina

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. cla: yes Signed the Google CLA Optimizer WS:Perf Work stream for Metrics, Performance and Optimizer
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@schlessera @westonruter @googlebot