Add paragraph about serverside rendering to README #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
approved these changes
Jun 12, 2020
|
Plugin builds for dfe1e96 are ready 🛎️!
|
A few tweaks to wording and "unpacking" of LCP acronym.
A few tweaks to wording and "unpacking" LCP acronym.
westonruter
requested changes
Jun 13, 2020
Great point/catch. I am going to make a small tweak... |
|
Suggestion of a suggestion of a suggestion:
I love it. Diff inception. |
westonruter
approved these changes
Jun 13, 2020
westonruter
approved these changes
Jun 14, 2020
westonruter
added a commit
that referenced
this pull request
Jun 14, 2020
* Add paragraph about serverside rendering to README * Update readme.md A few tweaks to wording and "unpacking" of LCP acronym. * Update readme.txt A few tweaks to wording and "unpacking" LCP acronym. * Improve SSR description Co-authored-by: Alberto A. Medina <aa.medina@gmail.com> Co-authored-by: Weston Ruter <westonruter@google.com>
|
The "full integration" was originally meant to refer to the AMP Optimizer library in the PHP ecosystem, for which we don't have a link yet, but which will soon be a thing. |
|
Got it; that makes sense. For now the wording reads well and corresponds
precisely to the current state. We will calibrate as the library and the
integration evolve. The important point is to convey the fact that the AMP
plugin provides the capability of generating optimized AMP with server-side
rendering out of the box.
…On Sun, Jun 14, 2020 at 12:07 AM Alain Schlesser ***@***.***> wrote:
The "full integration" was originally meant to refer to the AMP Optimizer
library in the PHP ecosystem, for which we don't have a link yet, but which
will soon be a thing.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4841 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD3R2NIJSDL65YUUEZHBALRWRZMNANCNFSM4N4XBBZA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a short paragraph with marketing buzz about the serverside rendering and the AMP optimizer.
Checklist